Skip to content

feat: deprecate mongo db like QL syntax in redis and support native QL#645

Merged
JoanFM merged 7 commits into
mainfrom
feat-redis-ql
Oct 18, 2022
Merged

feat: deprecate mongo db like QL syntax in redis and support native QL#645
JoanFM merged 7 commits into
mainfrom
feat-redis-ql

Conversation

@alaeddine-13

@alaeddine-13 alaeddine-13 commented Oct 18, 2022

Copy link
Copy Markdown
Member

Support native Redis QL and deprecate mongo DB like QL in Redis filtering.

  • Redis filtering
  • docs
  • tests

closes: #639

@codecov

codecov Bot commented Oct 18, 2022

Copy link
Copy Markdown

Codecov Report

Merging #645 (7f3a651) into main (125eb3a) will decrease coverage by 0.14%.
The diff coverage is 92.85%.

❗ Current head 7f3a651 differs from pull request most recent head 6645353. Consider uploading reports for the commit 6645353 to get more accurate results

@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
- Coverage   85.02%   84.88%   -0.15%     
==========================================
  Files         133      133              
  Lines        6718     6753      +35     
==========================================
+ Hits         5712     5732      +20     
- Misses       1006     1021      +15     
Flag Coverage Δ
docarray 84.88% <92.85%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/redis/backend.py 96.58% <ø> (ø)
docarray/array/storage/redis/find.py 86.36% <91.66%> (-7.76%) ⬇️
docarray/array/mixins/find.py 88.65% <100.00%> (ø)
docarray/array/mixins/evaluation.py 84.12% <0.00%> (-4.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JoanFM JoanFM left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @NicholasDunham input, but looks good to me

@JoanFM JoanFM requested a review from NicholasDunham October 18, 2022 07:08

@JohannesMessner JohannesMessner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicholasDunham NicholasDunham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammatical changes

Comment thread docs/advanced/document-store/redis.md Outdated
Comment thread docs/advanced/document-store/redis.md Outdated
Comment thread docs/advanced/document-store/redis.md Outdated
Comment thread docs/advanced/document-store/redis.md Outdated
Comment thread docs/advanced/document-store/redis.md Outdated
Comment thread docs/advanced/document-store/redis.md Outdated
alaeddine-13 and others added 2 commits October 18, 2022 15:45
Co-authored-by: Nicholas Dunham <11730795+NicholasDunham@users.noreply.github.com>
Signed-off-by: AlaeddineAbdessalem <alaeddine-13@live.fr>
Co-authored-by: Nicholas Dunham <11730795+NicholasDunham@users.noreply.github.com>
Signed-off-by: AlaeddineAbdessalem <alaeddine-13@live.fr>

@NicholasDunham NicholasDunham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoanFM JoanFM merged commit 6a532b3 into main Oct 18, 2022
@JoanFM JoanFM deleted the feat-redis-ql branch October 18, 2022 14:53
@github-actions

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat-redis-ql--jina-docs.netlify.app 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove custom QL for redis

4 participants