feat: deprecate mongo db like QL syntax in redis and support native QL#645
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #645 +/- ##
==========================================
- Coverage 85.02% 84.88% -0.15%
==========================================
Files 133 133
Lines 6718 6753 +35
==========================================
+ Hits 5712 5732 +20
- Misses 1006 1021 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JoanFM
approved these changes
Oct 18, 2022
JoanFM
left a comment
Member
There was a problem hiding this comment.
Let's wait for @NicholasDunham input, but looks good to me
NicholasDunham
suggested changes
Oct 18, 2022
NicholasDunham
left a comment
Contributor
There was a problem hiding this comment.
Minor grammatical changes
Co-authored-by: Nicholas Dunham <11730795+NicholasDunham@users.noreply.github.com> Signed-off-by: AlaeddineAbdessalem <alaeddine-13@live.fr>
Co-authored-by: Nicholas Dunham <11730795+NicholasDunham@users.noreply.github.com> Signed-off-by: AlaeddineAbdessalem <alaeddine-13@live.fr>
|
📝 Docs are deployed on https://ft-feat-redis-ql--jina-docs.netlify.app 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support native Redis QL and deprecate mongo DB like QL in Redis filtering.
closes: #639