Improve directory attribute refactor - Break up PR #18161 - Part 2#18196
Merged
psfinaki merged 2 commits intoJan 8, 2025
Conversation
Contributor
✅ No release notes required |
KevinRansom
force-pushed
the
ImproveDirectoryAttribute.sometests
branch
from
13c8b3b to
bc81456
Compare
T-Gro
approved these changes
Jan 3, 2025
T-Gro
left a comment
T-Gro
left a comment
Member
There was a problem hiding this comment.
(Approving the part which adds on Part 1, merge only after Part 1 gets merged)
KevinRansom
force-pushed
the
ImproveDirectoryAttribute.sometests
branch
from
75153dd to
400a8fa
Compare
Contributor
Author
|
|
Contributor
|
Unrelated test failure: |
psfinaki
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains all of the modified test cases that are not in tests\FSharp.Compiler.ComponentTests\EmittedIL.
Also deletes:
The tests were duplicated and had been updated in:
Moved MethodResolution.fs into a subdirectory and added baselines.
Note it also contains the commit that updates the test framework from part 1
/cc @T-Gro