Fix Packagemanager behaviour in Visual Studio#18435
Merged
Merged
Conversation
T-Gro
approved these changes
Apr 2, 2025
T-Gro
added
the
NO_RELEASE_NOTES
Contributor
|
psfinaki
approved these changes
Apr 2, 2025
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
Bot
moved this from In Progress
to Done
in F# Compiler and Tooling
This was referenced May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #18393
The issue happens when there are multiple #r "nugets: " in the script, when editing the second package management line causes the currently edited line to be submitted.
The fix is to remove the line under the caret from the submission. All other lines should be submitted. Additionally improve the GetTextView() to use the cached view. Which improves the reliability of the editing PM experience.