Skip to content

Checker: don't capture environment for checked modules#18519

Merged
T-Gro merged 5 commits into
dotnet:mainfrom
auduchinok:completion-env2
Apr 30, 2025
Merged

Checker: don't capture environment for checked modules#18519
T-Gro merged 5 commits into
dotnet:mainfrom
auduchinok:completion-env2

Conversation

@auduchinok

Copy link
Copy Markdown
Member

Fixes #18518.

This PR prevents adding the environment for the checked module.

@github-actions

github-actions Bot commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Warning

No PR link found in some release notes, please consider adding it.

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md No current pull request URL (#18519) found, please consider adding it

@auduchinok

Copy link
Copy Markdown
Member Author

OK, this approach seems to work. Since we only seem to want these captured environments in the IDE features (and they seem to break things there), I wonder what if we never add them. I've pushed another commit just to check it.

@auduchinok

Copy link
Copy Markdown
Member Author

This is ready.

@auduchinok auduchinok changed the title Checker: don't add environment for the checked non-recursive module Checker: don't capture environment for checked modules Apr 29, 2025
@T-Gro T-Gro enabled auto-merge (squash) April 29, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Code completion considers types from own namespace non-imported

4 participants