Skip to content

[aws] Fix event.created in CloudTrail data stream#2325

Merged
andrewkroh merged 1 commit into
elastic:masterfrom
andrewkroh:aws/fix-event-created-cloudtrail
Dec 9, 2021
Merged

[aws] Fix event.created in CloudTrail data stream#2325
andrewkroh merged 1 commit into
elastic:masterfrom
andrewkroh:aws/fix-event-created-cloudtrail

Conversation

@andrewkroh

@andrewkroh andrewkroh commented Dec 9, 2021

Copy link
Copy Markdown
Member

What does this PR do?

event.created was being set to the CloudTrail eventTime rather than the time that Filebeat created the document.

Fixes #2324

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] I have verified that Kibana version constraints are current according to guidelines.

Related issues

@andrewkroh andrewkroh added bug Something isn't working, use only for issues Integration:aws AWS Team:Integrations Label for the Integrations team Team:Security-External Integrations labels Dec 9, 2021
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine

elasticmachine commented Dec 9, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-09T04:20:50.296+0000

  • Duration: 28 min 23 sec

  • Commit: a77a340

Test stats 🧪

Test Results
Failed 0
Passed 303
Skipped 0
Total 303

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source file had extra newlines in it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like something that shouldn't result in an output.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I raised elastic/elastic-package#616 to catch these in elastic-package lint and format.

event.created was being set to the CloudTrail eventTime rather than the time that Filebeat created the document.

Fixes #2324
@andrewkroh andrewkroh merged commit 8471382 into elastic:master Dec 9, 2021
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
event.created was being set to the CloudTrail eventTime rather than the time that Filebeat created the document.

Fixes elastic#2324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:aws AWS Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aws] CloudTrail pipeline sets event.created incorrectly

3 participants