Skip to content

[kubernetes] Add missed ecs fields#3054

Merged
tetianakravchenko merged 6 commits into
elastic:mainfrom
tetianakravchenko:k8s-update-fields
Apr 12, 2022
Merged

[kubernetes] Add missed ecs fields#3054
tetianakravchenko merged 6 commits into
elastic:mainfrom
tetianakravchenko:k8s-update-fields

Conversation

@tetianakravchenko

@tetianakravchenko tetianakravchenko commented Apr 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Signed-off-by: Tetiana Kravchenko tetiana.kravchenko@elastic.co

What does this PR do?

In elastic/beats#31020 were added container fields, those fields should be added in all affected integration packages accordingly.
This PR is similar to the #3056 and #3059

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@tetianakravchenko
add missed ecs fields
dfb957f 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko requested a review from a team as a code owner April 11, 2022 12:01
@elasticmachine

elasticmachine commented Apr 11, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-12T07:16:53.790+0000

  • Duration: 47 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 116
Skipped 0
Total 116

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@tetianakravchenko
add missed fields to the state_* datastreams
4396586 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
run elastic-package build; update readme
015554c 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
revert changes
ff72e36 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
clean up
134f62a 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
MichaelKatsoulis
MichaelKatsoulis reviewed Apr 11, 2022
View reviewed changes
Comment thread packages/kubernetes/data_stream/state_container/fields/ecs.yml Outdated
name: orchestrator.cluster.name
- external: ecs
name: orchestrator.cluster.url
- name: container.cpu.usage

@MichaelKatsoulis MichaelKatsoulis Apr 11, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new fields are populated only by pod and container metricset(link). They are not needed in state_pod and state_container

@tetianakravchenko tetianakravchenko Apr 12, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 9c5ae4e

@tetianakravchenko
remove ecs fields from state_* metricsets
9c5ae4e 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
MichaelKatsoulis
MichaelKatsoulis approved these changes Apr 12, 2022
View reviewed changes

@MichaelKatsoulis MichaelKatsoulis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tetianakravchenko tetianakravchenko merged commit 4f12017 into elastic:main Apr 12, 2022
@andrewkroh andrewkroh changed the title Add missed ecs fields [kubernetes] Add missed ecs fields Apr 12, 2022
This was referenced Apr 13, 2022
Closed
Closed
@tetianakravchenko tetianakravchenko self-assigned this Apr 13, 2022
@tetianakravchenko tetianakravchenko mentioned this pull request Apr 13, 2022
Closed
7 tasks
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@tetianakravchenko
Add missed ecs fields (elastic#3054)
9f8c361 
* add missed ecs fields

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add missed fields to the state_* datastreams

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* run elastic-package build; update readme

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* revert changes

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* clean up

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* remove ecs fields from state_* metricsets

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelKatsoulis MichaelKatsoulis MichaelKatsoulis approved these changes
@gsantoro gsantoro Awaiting requested review from gsantoro

Assignees

@tetianakravchenko tetianakravchenko

Labels

Integration:kubernetes Kubernetes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tetianakravchenko @elasticmachine @MichaelKatsoulis @andrewkroh