Skip to content

[AWS][S3] Add dimensions field to s3_daily_storage and s3_request#6666

Merged
tetianakravchenko merged 5 commits into
elastic:mainfrom
tetianakravchenko:aws-s3-dimensions
Jun 29, 2023
Merged

[AWS][S3] Add dimensions field to s3_daily_storage and s3_request#6666
tetianakravchenko merged 5 commits into
elastic:mainfrom
tetianakravchenko:aws-s3-dimensions

Conversation

@tetianakravchenko

@tetianakravchenko tetianakravchenko commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Add dimensions metadata fields to 2 data_streams

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@tetianakravchenko
aws/s3 dimensions field
e77c5d2 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko requested a review from a team as a code owner June 22, 2023 07:20
@tetianakravchenko
fix conflicts
8758ea5 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
fix the PR link
2ad8697 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@elasticmachine

elasticmachine commented Jun 22, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-28T11:34:19.911+0000

  • Duration: 53 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 194
Skipped 4
Total 198

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

constanca-m
constanca-m approved these changes Jun 22, 2023
View reviewed changes

@constanca-m constanca-m left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another PR open that deletes the dimension.* fields and updates the md files

@tetianakravchenko tetianakravchenko requested a review from a team June 22, 2023 08:39
@tetianakravchenko

tetianakravchenko commented Jun 22, 2023

Copy link
Copy Markdown
Contributor Author

There is another #6648 open that deletes the dimension.* fields and updates the md files

thanks! I will fix conflicts when merged

@tetianakravchenko
run elastic-package build
d4cd267 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@constanca-m constanca-m mentioned this pull request Jun 28, 2023
Closed
@tetianakravchenko
merge main branch; fix conflicts
6fd7889 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@elasticmachine

elasticmachine commented Jun 28, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -2.25
Classes 93.75% (15/16) 👎 -2.25
Methods 85.714% (240/280) 👎 -2.332
Lines 85.925% (7387/8597) 👎 -2.29
Conditionals 100.0% (0/0) 💚

@tetianakravchenko tetianakravchenko merged commit 225af28 into elastic:main Jun 29, 2023
@tetianakravchenko tetianakravchenko deleted the aws-s3-dimensions branch June 29, 2023 08:02
@elasticmachine

elasticmachine commented Jun 29, 2023

Copy link
Copy Markdown

Package aws - 1.45.7 containing this change is available at https://epr.elastic.co/search?package=aws

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@tetianakravchenko
[AWS][S3] Add dimensions field to s3_daily_storage and s3_request (el…
6850461 
…astic#6666)

* aws/s3 dimensions field

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* fix the PR link

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* run elastic-package build

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

---------

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@constanca-m constanca-m constanca-m approved these changes
@agithomas agithomas Awaiting requested review from agithomas
@kaiyan-sheng kaiyan-sheng Awaiting requested review from kaiyan-sheng
+1 more reviewer
@tdancheva tdancheva tdancheva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Integration:aws AWS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tetianakravchenko @elasticmachine @constanca-m @tdancheva @andrewkroh