Add k8s integration tests by ChrsMark · Pull Request #886 · elastic/integrations

ChrsMark · 2021-04-06T12:56:05Z

What does this PR do?

This PR adds tests for k8s package using k8s service deployer.

Related to #822

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

elasticmachine · 2021-04-06T13:04:55Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #886 updated
Start Time: 2021-04-22T12:34:17.314+0000
Duration: 32 min 51 sec
Commit: 99c86ed

Test stats 🧪

Test	Results
Failed	0
Passed	359
Skipped	0
Total	359

Trends 🧪

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

ChrsMark · 2021-04-06T14:48:39Z

@mtojek @ycombinator I think that this scenario might be a good candidate to put flakiness because we don't wait for custom resources to be ready so we might fail to get metrics from the endpoints since the service is not yet ready. I think this happens here with kube-state-metrics.

I wonder if we could add sth like "wait for healthy" on k8s service deployer to ensure that custom resource is ready.

ycombinator · 2021-04-06T15:18:14Z

I wonder if we could add sth like "wait for healthy" on k8s service deployer to ensure that custom resource is ready.

Sounds good to me. We have a waitUntilTrue function that you might be able to reuse for this.

mtojek · 2021-04-06T20:09:05Z

Sounds good to me. We have a waitUntilTrue function that you might be able to reuse for this.

I think this one runs on a different level. We need something on the service's Setup() level.

mtojek · 2021-04-07T07:37:45Z

One more question, @ChrsMark .

Do you have any proposal for the wait for healthy? Would you like us to use any particular API/method? I'm going to work on this soon/today.

ChrsMark · 2021-04-07T07:48:06Z

Hey! Since we have to do with metrics collection and mostly http maybe using liveness checks can work here. In this way when you add a custom resource you are responsible for defining the liveness probe and then the deployer will check the status of the pod and wait until ready. Feel free to ping me when on it to further brainstorm on this.

mtojek · 2021-04-07T08:13:33Z

Feel free to ping me when on it to further brainstorm on this.

What if custom definitions describe multiple pods and some of them hasn't been created yet (we can see that there is one pod in progress)?

…on_tests

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

mtojek · 2021-04-19T12:34:38Z

FYI I pushed the update of elastic-package to the master branch.

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

…on_tests

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

…on_tests

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

…on_tests

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

ChrsMark · 2021-04-21T09:38:47Z

Blocked on elastic/elastic-package#332

…on_tests

mtojek · 2021-04-21T14:06:55Z

+    - name: pod.uid
+      type: keyword
+      description: >
+        Kubernetes Pod UID


nit: pod vs Pod (casing consistency)

mtojek · 2021-04-21T14:07:32Z

+    - name: deployment.name
+      type: keyword
+      description: >
+        Kubernetes deployment name


nit: not sure if we need the prefix "Kubernetes" in every field description

this is how we have it in Beats too, I don't think this is a bad pattern.

mtojek · 2021-04-21T14:08:32Z

-      - http://{{Hostname}}:10251
+      - https://0.0.0.0:10257
+    bearer_token_file: /var/run/secrets/kubernetes.io/serviceaccount/token
+    ssl.verification_mode: "none"


nit: why exactly is the ssl.verification_mode = none? is it because we're lacking some permissions or certs?

We use the token for the auth part but since the server is https we need a CA or --insecure( ssl.verification_mode: "none") flag to access it. We follow this pattern for kubelet's api too and most probably works fine in real world clusters. If users want to use CAs they can too but they need to provide it properly. (we have some similar cases with kubelet's api access in openshift and we had to find the proper CA generated by k8s so as to use it with Beats too). For this testing scenario I think we are safe.

mtojek · 2021-04-21T14:09:54Z

@@ -0,0 +1,108 @@
+apiVersion: rbac.authorization.k8s.io/v1


Did you consider using a package scoped _dev/deploy that can be common for all data streams?

mtojek · 2021-04-21T14:10:49Z

 name: kubernetes
 title: Kubernetes
-version: 0.4.5
+version: 0.5.0


Would you mind updating the changelog as you added new field definitions?

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

mtojek

Ship it, please!

ChrsMark added 4 commits April 6, 2021 09:22

complete kubelet realted tests

06cfb67

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

wip

55612b1

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

add more tests

29d0609

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

Add proxy tests

c319e64

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

split kube-state-metrics files

375177f

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

ChrsMark force-pushed the add_k8s_integration_tests branch from 5752d32 to 375177f Compare April 6, 2021 14:16

mtojek mentioned this pull request Apr 8, 2021

Kubernetes service deployer: wait for resources elastic/elastic-package#316

Closed

ChrsMark mentioned this pull request Apr 14, 2021

Add cluster config for kind create cluster command #908

Merged

ChrsMark added 3 commits April 15, 2021 15:47

Merge remote-tracking branch 'upstream/master' into add_k8s_integrati…

48190b1

…on_tests

Merge remote-tracking branch 'upstream/master' into add_k8s_integrati…

ab65c79

…on_tests

fix datastreams

bf7a8e2

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

ChrsMark force-pushed the add_k8s_integration_tests branch from 8810952 to bf7a8e2 Compare April 19, 2021 10:52

mtojek mentioned this pull request Apr 19, 2021

Update dependency on elastic-package #918

Merged

ChrsMark added 2 commits April 19, 2021 15:59

lint

5392175

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

Merge remote-tracking branch 'upstream/master' into add_k8s_integrati…

bd8e9f3

…on_tests

ChrsMark mentioned this pull request Apr 19, 2021

Add services to cluster role so as Agent to be able to watch k8s svc elastic/elastic-package#326

Merged

ChrsMark added 6 commits April 19, 2021 19:12

Add fields

f1eb9bb

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

Remove docker based test files for k8s package

3596cab

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

Bump up package version

06e5c2a

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

Update package

997f20d

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

Merge remote-tracking branch 'upstream/master' into add_k8s_integrati…

f3715bf

…on_tests

Fix fields

e81cda3

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

ChrsMark added 2 commits April 20, 2021 14:53

Merge remote-tracking branch 'upstream/master' into add_k8s_integrati…

3f255d4

…on_tests

fix datastreams

848acde

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

Merge remote-tracking branch 'upstream/master' into add_k8s_integrati…

34577b6

…on_tests

ChrsMark requested a review from mtojek April 21, 2021 14:00

mtojek reviewed Apr 21, 2021

View reviewed changes

fix casing for consistency

a91cae2

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

ChrsMark force-pushed the add_k8s_integration_tests branch from ba06b38 to a91cae2 Compare April 22, 2021 10:44

Move deploy files to package level

99c86ed

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

mtojek self-requested a review April 22, 2021 13:13

mtojek approved these changes Apr 22, 2021

View reviewed changes

ChrsMark merged commit fd944b8 into elastic:master Apr 22, 2021

ChrsMark mentioned this pull request Apr 22, 2021

Add integrations tests for k8s package #822

Closed

Uh oh!

Conversation

ChrsMark commented Apr 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Uh oh!

elasticmachine commented Apr 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

Trends 🧪

Uh oh!

ChrsMark commented Apr 6, 2021

Uh oh!

ycombinator commented Apr 6, 2021

Uh oh!

mtojek commented Apr 6, 2021

Uh oh!

mtojek commented Apr 7, 2021

Uh oh!

ChrsMark commented Apr 7, 2021

Uh oh!

mtojek commented Apr 7, 2021

Uh oh!

mtojek commented Apr 19, 2021

Uh oh!

ChrsMark commented Apr 21, 2021

Uh oh!

mtojek Apr 21, 2021

Choose a reason for hiding this comment

Uh oh!

mtojek Apr 21, 2021

Choose a reason for hiding this comment

Uh oh!

ChrsMark Apr 22, 2021

Choose a reason for hiding this comment

Uh oh!

mtojek Apr 21, 2021

Choose a reason for hiding this comment

Uh oh!

ChrsMark Apr 22, 2021

Choose a reason for hiding this comment

Uh oh!

mtojek Apr 21, 2021

Choose a reason for hiding this comment

Uh oh!

mtojek Apr 21, 2021

Choose a reason for hiding this comment

Uh oh!

mtojek left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ChrsMark commented Apr 6, 2021 •

edited

Loading

elasticmachine commented Apr 6, 2021 •

edited

Loading