Skip to content

fix: error using webcrypto.subtle.importKey()#40070

Merged
codebytere merged 1 commit into
mainfrom
crypto-aes-key-undefined
Oct 5, 2023
Merged

fix: error using webcrypto.subtle.importKey()#40070
codebytere merged 1 commit into
mainfrom
crypto-aes-key-undefined

Conversation

@codebytere

Copy link
Copy Markdown
Member

Description of Change

Closes #40002.
Refs nodejs/node#46067.

Fixes an issue where using webcrypto.subtle.importKey() could error and fail if SharedArrayBuffers are not defined.

Checklist

Release Notes

Notes: Fixed an issue where using webcrypto.subtle.importKey() could error and fail if SharedArrayBuffers are not defined.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/27-x-y PR should also be added to the "27-x-y" branch. labels Oct 2, 2023
@codebytere codebytere requested a review from a team as a code owner October 2, 2023 14:08
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Oct 2, 2023

@jkleinsc jkleinsc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Oct 3, 2023
@codebytere codebytere force-pushed the crypto-aes-key-undefined branch from 5dcaac6 to 495f6a1 Compare October 4, 2023 08:41
@codebytere codebytere merged commit b3a1c6d into main Oct 5, 2023
@codebytere codebytere deleted the crypto-aes-key-undefined branch October 5, 2023 08:46
@release-clerk

release-clerk Bot commented Oct 5, 2023

Copy link
Copy Markdown

Release Notes Persisted

Fixed an issue where using webcrypto.subtle.importKey() could error and fail if SharedArrayBuffers are not defined.

@trop

trop Bot commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "27-x-y", please check out #40100

@trop trop Bot added in-flight/27-x-y merged/27-x-y PR was merged to the "27-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. in-flight/27-x-y labels Oct 5, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
fix: error using webcrypto.subtle.importKey()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged/27-x-y PR was merged to the "27-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SubtleCrypto.importKey crash with "Cannot read properties of undefined" on Electron 27 Beta

2 participants