flattened out that do/while loop that only ran once in DataChannelRer…#778
Merged
Merged
Conversation
5 tasks
JakubVanek
reviewed
Dec 30, 2020
| byteBuffer.clear(); | ||
| channel.position(0); | ||
| int n = channel.read(byteBuffer); | ||
| if (n == -1) { |
Contributor
There was a problem hiding this comment.
I think this branch should handle the n == 0 case as well. I'm not sure when would this happen, but if it happens then the code below will break (bytes[-1] is invalid).
Member
There was a problem hiding this comment.
It is not a bad idea.
I will merge this version and later we will refine with that idea
Contributor
There was a problem hiding this comment.
This was already added: c1b7897 (later commit in this PR)
JakubVanek
reviewed
Dec 30, 2020
| } while (n <= 0); | ||
| byteBuffer.clear(); | ||
| channel.position(0); | ||
| int n = channel.read(byteBuffer); |
Contributor
There was a problem hiding this comment.
The position() + read() calls can be merged together:
EDIT: javadocs: https://docs.oracle.com/javase/7/docs/api/java/nio/channels/FileChannel.html#read(java.nio.ByteBuffer,%20long)
…d tightened up the readString method - Jakub's review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.