Skip to content

feat: owner reference validity check regarding scope and namespace#5701

Merged
manusa merged 6 commits into
fabric8io:mainfrom
csviri:owner-reference-check
Jan 17, 2024
Merged

feat: owner reference validity check regarding scope and namespace#5701
manusa merged 6 commits into
fabric8io:mainfrom
csviri:owner-reference-check

Conversation

@csviri

@csviri csviri commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

Description

Checks is owner references are correct in terms of scope and namespaces:

  1. The referenced object should not be from different namespace (if both are namespaced objects)
  2. Cluster scoped object should not reference namespace scoped object

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@csviri csviri changed the title Owner reference check fix: owner reference validity check regarding scope and namespace Jan 10, 2024
@csviri csviri marked this pull request as ready for review January 10, 2024 10:32
@csviri csviri changed the title fix: owner reference validity check regarding scope and namespace feat: owner reference validity check regarding scope and namespace Jan 10, 2024
@manusa manusa self-assigned this Jan 17, 2024
csviri and others added 6 commits January 17, 2024 06:26
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
…/io/fabric8/kubernetes/api/model/HasMetadata.java

Co-authored-by: Rohan Kumar  <rohan.kumar.kanojia@gmail.com>
@manusa manusa force-pushed the owner-reference-check branch from 55a2228 to 88cea1e Compare January 17, 2024 05:28

@manusa manusa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa removed their assignment Jan 17, 2024
@manusa manusa added this to the 6.11.0 milestone Jan 17, 2024
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants