Skip to content

Fix materialize bug with RedisCluster #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adchia merged 35 commits into from
Feb 17, 2022
Merged

Fix materialize bug with RedisCluster #2311

Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
4134113
Fix materialization bug
kevjumba Feb 15, 2022
926260b
oops removed something when i was copy pasting
kevjumba Feb 15, 2022
b4e9ac0
Test github workflow
kevjumba Feb 16, 2022
1281b2d
lint
kevjumba Feb 16, 2022
b404f4f
transfer to unit_tests
kevjumba Feb 16, 2022
f8dab19
Brute force implementation
kevjumba Feb 16, 2022
c05d2b2
Brute force implementation add gcc
kevjumba Feb 16, 2022
e53c75b
Brute force implementation add gcc
kevjumba Feb 16, 2022
eafc27d
Brute force implementation add gcc
kevjumba Feb 16, 2022
bbbb325
Brute force implementation add gcc
kevjumba Feb 16, 2022
ac08a7b
Continue fixing...
kevjumba Feb 16, 2022
fbb8b08
Remove gcc setup
kevjumba Feb 16, 2022
ef14ff4
Add integration test
kevjumba Feb 16, 2022
9916649
fix error
kevjumba Feb 16, 2022
6b82098
fix error
kevjumba Feb 16, 2022
89c1da8
Add setup
kevjumba Feb 16, 2022
0e9f1b3
temp fix to get integration tests to work
kevjumba Feb 16, 2022
ca3aa7b
temp fix to get integration tests to work
kevjumba Feb 16, 2022
03f76f1
temp fix to get integration tests to work
kevjumba Feb 16, 2022
6aeb5f4
temp fix to get integration tests to work
kevjumba Feb 16, 2022
c32ed21
Fix integration even more
kevjumba Feb 16, 2022
68c9b61
Fix integration even more
kevjumba Feb 16, 2022
caeb757
Fix lint
kevjumba Feb 16, 2022
8b9f2f1
only run one test
kevjumba Feb 16, 2022
1f060e0
Do some more integration testing
kevjumba Feb 16, 2022
931dc23
Do some more integration testing by adding bug to make sure no false …
kevjumba Feb 16, 2022
41f7c75
Integration testing works
kevjumba Feb 16, 2022
174af8e
Clean upu code
kevjumba Feb 16, 2022
d818c0a
Add redis cluster script for starting a redis cluster
kevjumba Feb 16, 2022
b2903f8
Reset integration yml file
kevjumba Feb 16, 2022
0b5dabd
lint
kevjumba Feb 16, 2022
1a4a155
Clean up
kevjumba Feb 16, 2022
52f239d
Fix how to guide lint
kevjumba Feb 16, 2022
a21e13f
add fixtures and remove excess code
kevjumba Feb 17, 2022
9c59fcc
lint
kevjumba Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix integration even more 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Feb 16, 2022
commit 68c9b616343c2bf89455fe2afa01d6c94b8d1dfb
58 changes: 29 additions & 29 deletions sdk/python/tests/integration/feature_repos/repo_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,35 +69,35 @@
if os.getenv("FEAST_IS_LOCAL_TEST", "False") != "True":
DEFAULT_FULL_REPO_CONFIGS.extend(
[
# GCP configurations
# IntegrationTestRepoConfig(
# provider="gcp",
# offline_store_creator=BigQueryDataSourceCreator,
# online_store="datastore",
# ),
# IntegrationTestRepoConfig(
# provider="gcp",
# offline_store_creator=BigQueryDataSourceCreator,
# online_store=REDIS_CONFIG,
# ),
# # AWS configurations
# IntegrationTestRepoConfig(
# provider="aws",
# offline_store_creator=RedshiftDataSourceCreator,
# online_store=DYNAMO_CONFIG,
# python_feature_server=True,
# ),
# IntegrationTestRepoConfig(
# provider="aws",
# offline_store_creator=RedshiftDataSourceCreator,
# online_store=REDIS_CONFIG,
# ),
# # Snowflake configurations
# IntegrationTestRepoConfig(
# provider="aws", # no list features, no feature server
# offline_store_creator=SnowflakeDataSourceCreator,
# online_store=REDIS_CONFIG,
# ),
GCP configurations
IntegrationTestRepoConfig(
provider="gcp",
offline_store_creator=BigQueryDataSourceCreator,
online_store="datastore",
),
IntegrationTestRepoConfig(
provider="gcp",
offline_store_creator=BigQueryDataSourceCreator,
online_store=REDIS_CONFIG,
),
# AWS configurations
IntegrationTestRepoConfig(
provider="aws",
offline_store_creator=RedshiftDataSourceCreator,
online_store=DYNAMO_CONFIG,
python_feature_server=True,
),
IntegrationTestRepoConfig(
provider="aws",
offline_store_creator=RedshiftDataSourceCreator,
online_store=REDIS_CONFIG,
),
# Snowflake configurations
IntegrationTestRepoConfig(
provider="aws", # no list features, no feature server
offline_store_creator=SnowflakeDataSourceCreator,
online_store=REDIS_CONFIG,
),
]
)
full_repo_configs_module = os.environ.get(FULL_REPO_CONFIGS_MODULE_ENV_NAME)
Expand Down