Skip to content

chore: Add a source field in the feature view API #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
achals wants to merge 4 commits into from
Closed

chore: Add a source field in the feature view API #2524

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65e808b
fix: Support passing batch source to streaming sources for backfills
achals Apr 11, 2022
dc06cc2
fix tests
achals Apr 11, 2022
67c41b4
fix tests
achals Apr 11, 2022
d19cf5b
chore: Add a source field in the feature view API
achals Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Apr 11, 2022
commit dc06cc2351bf6eab8394d22e85fcea3bb79da93b
2 changes: 1 addition & 1 deletion sdk/python/tests/unit/test_data_sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ def test_push_with_batch():
batch_source=BigQuerySource(table="test.test"),
)
push_source_proto = push_source.to_proto()
assert push_source_proto.HasField("batch_source")
assert push_source_proto.push_options is not None
assert push_source_proto.push_options.HasField("batch_source")

push_source_unproto = PushSource.from_proto(push_source_proto)

Expand Down