Skip to content

chore: Fix ODFV decorator #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 5 commits into from
Apr 12, 2022
Merged

chore: Fix ODFV decorator #2527

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a9677d
Enforce kwargs for ODFV decorator and switch from `features` to `schema`
felixwang9817 Apr 12, 2022
f1a057e
Fix ODFV decorators in docs
felixwang9817 Apr 12, 2022
7a1a630
Fix ODFV decorators in Java
felixwang9817 Apr 12, 2022
e8bb16c
Fix ODFV references in ui
felixwang9817 Apr 12, 2022
a63590c
Fix ODFV decorator in integration tests
felixwang9817 Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix ODFV references in ui 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
@felixwang9817
felixwang9817 committed Apr 12, 2022
commit e8bb16cba4930e404182d588fe4ec460f7a7ace4
2 changes: 1 addition & 1 deletion ui/feature_repo/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
# Define an on demand feature view which can generate new features based on
# existing feature views and RequestSource features
@on_demand_feature_view(
inputs={"credit_history": credit_history, "transaction": input_request,},
sources={"credit_history": credit_history, "transaction": input_request,},
schema=[
Field(name="transaction_gt_last_credit_card_due", dtype=Bool),
],
Expand Down
2 changes: 1 addition & 1 deletion ui/public/registry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@
},
"userDefinedFunction": {
"name": "transaction_gt_last_credit_card_due",
"body": "@on_demand_feature_view(\n inputs={\"credit_history\": credit_history, \"transaction\": input_request,},\n schema=[\n Field(name=\"transaction_gt_last_credit_card_due\", dtype=Bool),\n ],\n)\ndef transaction_gt_last_credit_card_due(inputs: pd.DataFrame) -> pd.DataFrame:\n df = pd.DataFrame()\n df[\"transaction_gt_last_credit_card_due\"] = (\n inputs[\"transaction_amt\"] > inputs[\"credit_card_due\"]\n )\n return df\n"
"body": "@on_demand_feature_view(\n sources={\"credit_history\": credit_history, \"transaction\": input_request,},\n schema=[\n Field(name=\"transaction_gt_last_credit_card_due\", dtype=Bool),\n ],\n)\ndef transaction_gt_last_credit_card_due(inputs: pd.DataFrame) -> pd.DataFrame:\n df = pd.DataFrame()\n df[\"transaction_gt_last_credit_card_due\"] = (\n inputs[\"transaction_amt\"] > inputs[\"credit_card_due\"]\n )\n return df\n"
}
},
"meta": {
Expand Down