Fix lint

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
feast-dev · feast-ci-bot · Aug 19, 2022 · Aug 5, 2022 · Aug 10, 2022 · Aug 10, 2022
commit 07fece53e3ba2bd7088d76b42342065c9de1aacb
@@ -21,7 +21,6 @@
 from feast.registry import BaseRegistry
 from feast.repo_config import RepoConfig
 from feast.saved_dataset import SavedDataset
-from feast.usage import RatioSampler, log_exceptions_and_usage, set_usage_attribute
 from feast.utils import (
     _convert_arrow_to_proto,
     _get_column_names,

@@ -1,41 +1,37 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT license.
 
-from dataclasses import asdict, dataclass
-from datetime import datetime, timedelta
+from datetime import datetime
 from typing import Any, Dict, List, Optional, Set, Tuple, Union
 
 import numpy as np
 import pandas
 import pyarrow
 import sqlalchemy
-from jinja2 import BaseLoader, Environment
 from pydantic.types import StrictStr
 from pydantic.typing import Literal
 from sqlalchemy import create_engine
 from sqlalchemy.engine import Engine
-from sqlalchemy.orm import Session, sessionmaker
-from feast.errors import InvalidEntityType
+from sqlalchemy.orm import sessionmaker
 
 from feast import FileSource, errors
 from feast.data_source import DataSource
+from feast.errors import InvalidEntityType
 from feast.feature_view import FeatureView
 from feast.infra.offline_stores import offline_utils
 from feast.infra.offline_stores.file_source import SavedDatasetFileStorage
-from feast.infra.offline_stores.offline_store import (
-    OfflineStore,
-    RetrievalJob,
-    RetrievalMetadata,
-)
+from feast.infra.offline_stores.offline_store import OfflineStore, RetrievalMetadata
 from feast.infra.offline_stores.offline_utils import (
     DEFAULT_ENTITY_DF_EVENT_TIMESTAMP_COL,
+    build_point_in_time_query,
+    get_feature_view_query_context,
 )
 from feast.infra.provider import RetrievalJob
 from feast.on_demand_feature_view import OnDemandFeatureView
 from feast.registry import BaseRegistry
 from feast.repo_config import FeastBaseModel, RepoConfig
 from feast.saved_dataset import SavedDatasetStorage
-from feast.infra.offline_stores.offline_utils import build_point_in_time_query, get_feature_view_query_context
+
 EntitySchema = Dict[str, np.dtype]
 
 
@@ -50,7 +46,6 @@ class MsSqlServerOfflineStoreConfig(FeastBaseModel):
      format: SQLAlchemy connection string, e.g. mssql+pyodbc://sa:yourStrong(!)Password@localhost:1433/feast_test?driver=ODBC+Driver+17+for+SQL+Server"""
 
 
-
 def make_engine(config: MsSqlServerOfflineStoreConfig) -> Engine:
     return create_engine(config.connection_string)
 
@@ -175,7 +170,11 @@ def get_historical_features(
 
         # Build a query context containing all information required to template the SQL query
         query_context = get_feature_view_query_context(
-            feature_refs, feature_views, registry, project, entity_df_timestamp_range=entity_df_event_timestamp_range,
+            feature_refs,
+            feature_views,
+            registry,
+            project,
+            entity_df_timestamp_range=entity_df_event_timestamp_range,
         )
 
         # TODO: Infer min_timestamp and max_timestamp from entity_df
@@ -187,7 +186,6 @@ def get_historical_features(
             entity_df_columns=table_schema.keys(),
             full_feature_names=full_feature_names,
             query_template=MULTIPLE_FEATURE_VIEW_POINT_IN_TIME_JOIN,
-
         )
         query = query.replace("`", "")
 
@@ -200,6 +198,7 @@ def get_historical_features(
         )
         return job
 
+
 def _assert_expected_columns_in_dataframe(
     join_keys: Set[str], entity_df_event_timestamp_col: str, entity_df: pandas.DataFrame
 ):
@@ -336,7 +335,7 @@ def _upload_entity_df_into_sqlserver_and_get_entity_schema(
 
     if type(entity_df) is str:
         # TODO: This should be a temporary table, right?
-        session.execute(f"SELECT * INTO {table_id} FROM ({entity_df}) t")
+        session.execute(f"SELECT * INTO {table_id} FROM ({entity_df}) t")  # type: ignore
 
         session.commit()
 
@@ -365,10 +364,11 @@ def _upload_entity_df_into_sqlserver_and_get_entity_schema(
 
     return entity_schema
 
+
 def _get_entity_df_event_timestamp_range(
     entity_df: Union[pandas.DataFrame, str],
     entity_df_event_timestamp_col: str,
-    engine: Session,
+    engine: Engine,
 ) -> Tuple[datetime, datetime]:
     if isinstance(entity_df, pandas.DataFrame):
         entity_df_event_timestamp = entity_df.loc[
@@ -398,10 +398,11 @@ def _get_entity_df_event_timestamp_range(
             entity_df_event_timestamp.max().to_pydatetime(),
         )
     else:
-         raise InvalidEntityType(type(entity_df))
+        raise InvalidEntityType(type(entity_df))
 
     return entity_df_event_timestamp_range
 
+
 # TODO: Optimizations
 #   * Use NEWID() instead of ROW_NUMBER(), or join on entity columns directly
 #   * Precompute ROW_NUMBER() so that it doesn't have to be recomputed for every query on entity_dataframe

@@ -219,7 +219,7 @@ def get_table_column_names_and_types(
             config.offline_store.connection_string
         )
         name_type_pairs = []
-        if (len(self.table_ref.split(".")) == 2):
+        if len(self.table_ref.split(".")) == 2:
             database, table_name = self.table_ref.split(".")
             columns_query = f"""
                 SELECT COLUMN_NAME, DATA_TYPE FROM INFORMATION_SCHEMA.COLUMNS

@@ -1,11 +1,7 @@
 import os
-import uuid
-from typing import Dict, List
-from venv import create
+from typing import Dict
 
 import pandas as pd
-from pyspark import SparkConf
-from pyspark.sql import SparkSession
 
 from feast.data_source import DataSource
 from feast.infra.offline_stores.contrib.mssql_offline_store.mssql import (

@@ -1,5 +1,4 @@
 from abc import ABC, abstractmethod
-from collections import defaultdict
 from datetime import datetime
 from pathlib import Path
 from typing import Any, Callable, Dict, List, Optional, Sequence, Tuple, Union

diff --git a/sdk/python/feast/infra/registry_stores/contrib/azure/registry_store.py b/sdk/python/feast/infra/registry_stores/contrib/azure/registry_store.py
@@ -21,7 +21,7 @@ def __init__(self, registry_config: RegistryConfig, repo_path: Path):
             import logging
 
             from azure.identity import DefaultAzureCredential
-            from azure.storage.blob import BlobClient, BlobServiceClient
+            from azure.storage.blob import BlobServiceClient
         except ImportError as e:
             from feast.errors import FeastExtrasDependencyImportError
 
@@ -59,9 +59,9 @@ def __init__(self, registry_config: RegistryConfig, repo_path: Path):
             self.blob = client.get_blob_client(
                 container=self._container, blob=self._path
             )
-        except:
+        except Exception as e:
             print(
-                "Could not connect to blob. Check the following\nIs the URL specified correctly?\nIs you IAM role set to Storage Blob Data Contributor?\n"
+                f"Could not connect to blob. Check the following\nIs the URL specified correctly?\nIs you IAM role set to Storage Blob Data Contributor? \n Errored out with exception {e}"
             )
 
         return
@@ -94,5 +94,5 @@ def _write_registry(self, registry_proto: RegistryProto):
         file_obj = TemporaryFile()
         file_obj.write(registry_proto.SerializeToString())
         file_obj.seek(0)
-        self.blob.upload_blob(file_obj, overwrite=True)
+        self.blob.upload_blob(file_obj, overwrite=True)  # type: ignore
         return
@@ -532,6 +532,7 @@ def bq_to_feast_value_type(bq_type_as_str: str) -> ValueType:
 
     return value_type
 
+
 def mssql_to_feast_value_type(mssql_type_as_str: str) -> ValueType:
     type_map = {
         "bigint": ValueType.FLOAT,
@@ -557,7 +558,6 @@ def mssql_to_feast_value_type(mssql_type_as_str: str) -> ValueType:
     return type_map[mssql_type_as_str.lower()]
 
 
-
 def redshift_to_feast_value_type(redshift_type_as_str: str) -> ValueType:
     # Type names from https://docs.aws.amazon.com/redshift/latest/dg/c_Supported_data_types.html
     type_map = {

diff --git a/sdk/python/feast/types.py b/sdk/python/feast/types.py
@@ -13,7 +13,6 @@
 # limitations under the License.
 from abc import ABC, abstractmethod
 from enum import Enum
-from multiprocessing.sharedctypes import Value
 from typing import Dict, Union
 
 from feast.value_type import ValueType