Skip to content

fix: Update sql.py #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 4 commits into from
Aug 17, 2022
Merged

fix: Update sql.py #3096

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f602f6c
Update sql.py
hao-affirm Aug 16, 2022
513e16a
add test
hao-affirm Aug 17, 2022
9cf3f05
add test
hao-affirm Aug 17, 2022
d3ae960
fix lint
hao-affirm Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/registry/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ def _apply_object(
):
self._maybe_init_project_metadata(project)

name = name or obj.name if hasattr(obj, "name") else None
name = name or (obj.name if hasattr(obj, "name") else None)
assert name, f"name needs to be provided for {obj}"

with self.engine.connect() as conn:
Expand Down
21 changes: 21 additions & 0 deletions sdk/python/tests/unit/test_sql_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,3 +551,24 @@ def test_apply_data_source(sql_registry):
assert registry_batch_source == batch_source

sql_registry.teardown()

@pytest.mark.skipif(
sys.platform == "darwin" and "GITHUB_REF" in os.environ,
reason="does not run on mac github actions",
)
@pytest.mark.parametrize(
"sql_registry",
[
lazy_fixture("mysql_registry"),
lazy_fixture("pg_registry"),
lazy_fixture("sqlite_registry"),
],
)
def test_update_infra(sql_registry):
# Create infra object
project = "project"
infra = sql_registry.get_infra(project=project)

# Should run update infra successfully
sql_registry.update_infra(infra, project)
sql_registry.teardown()