Skip to content

fix: Fix release workflow to release 0.24.0 #3138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 6 commits into from
Aug 25, 2022
Merged

fix: Fix release workflow to release 0.24.0 #3138

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
504b5cb
Fix
kevjumba Aug 24, 2022
32d40f1
fix
kevjumba Aug 24, 2022
9bfe931
temporary fix
kevjumba Aug 25, 2022
dca542e
Fix
kevjumba Aug 25, 2022
13f8364
Fix
kevjumba Aug 25, 2022
37396b7
Fix
kevjumba Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
temporary fix 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Aug 25, 2022
commit 9bfe931ea7add72f965112cbc27df54e1d8a8e2c
1 change: 1 addition & 0 deletions .github/workflows/build_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ jobs:
make install-go-ci-dependencies
git status
git restore go.mod go.sum
git restore sdk/
CIBW_BEFORE_TEST: "cd {project} && git status"
# py3.10 on MacOS does not work with Go so we have to install separately. Issue is tracked here: https://github.com/feast-dev/feast/issues/2881.
- name: Build py310 specific wheels for macos
Expand Down
62 changes: 31 additions & 31 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,40 +42,40 @@ jobs:
echo "Current version is ${CURRENT_VERSION}"
echo "Next version is ${NEXT_VERSION}"

publish-web-ui-npm:
if: github.repository == 'feast-dev/feast'
needs: get_dry_release_versions
runs-on: ubuntu-latest
env:
# This publish is working using an NPM automation token to bypass 2FA
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
CURRENT_VERSION: ${{ needs.get_dry_release_versions.outputs.current_version }}
NEXT_VERSION: ${{ needs.get_dry_release_versions.outputs.next_version }}
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: '17.x'
registry-url: 'https://registry.npmjs.org'
- name: Bump file versions (temporarily for Web UI publish)
run: python ./infra/scripts/release/bump_file_versions.py ${CURRENT_VERSION} ${NEXT_VERSION}
- name: Install yarn dependencies
working-directory: ./ui
run: yarn install
- name: Build yarn rollup
working-directory: ./ui
run: yarn build:lib
- name: Publish UI package
working-directory: ./ui
run: npm publish
env:
# This publish is working using an NPM automation token to bypass 2FA
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
# publish-web-ui-npm:
# if: github.repository == 'feast-dev/feast'
# needs: get_dry_release_versions
# runs-on: ubuntu-latest
# env:
# # This publish is working using an NPM automation token to bypass 2FA
# NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
# CURRENT_VERSION: ${{ needs.get_dry_release_versions.outputs.current_version }}
# NEXT_VERSION: ${{ needs.get_dry_release_versions.outputs.next_version }}
# steps:
# - uses: actions/checkout@v2
# - uses: actions/setup-node@v2
# with:
# node-version: '17.x'
# registry-url: 'https://registry.npmjs.org'
# - name: Bump file versions (temporarily for Web UI publish)
# run: python ./infra/scripts/release/bump_file_versions.py ${CURRENT_VERSION} ${NEXT_VERSION}
# - name: Install yarn dependencies
# working-directory: ./ui
# run: yarn install
# - name: Build yarn rollup
# working-directory: ./ui
# run: yarn build:lib
# - name: Publish UI package
# working-directory: ./ui
# run: npm publish
# env:
# # This publish is working using an NPM automation token to bypass 2FA
# NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

release:
name: release
runs-on: ubuntu-latest
needs: publish-web-ui-npm
#needs: publish-web-ui-npm
env:
GITHUB_TOKEN: ${{ github.event.inputs.token }}
GIT_AUTHOR_NAME: feast-ci-bot
Expand All @@ -96,6 +96,6 @@ jobs:
run: |
npx -p @semantic-release/changelog -p @semantic-release/git -p @semantic-release/exec -p semantic-release semantic-release --dry-run
- name: Release
if: github.event.inputs.dry_run == 'false' && always() # Temporary fix to make sure the release runs
if: github.event.inputs.dry_run == 'false'
run: |
npx -p @semantic-release/changelog -p @semantic-release/git -p @semantic-release/exec -p semantic-release semantic-release