Skip to content

fix: Handle complex Spark data types in SparkSource #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
Aug 30, 2022
Merged

fix: Handle complex Spark data types in SparkSource #3154

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44f79e4
Make sure data types are strings
rebstastic Aug 30, 2022
b1164b2
Lint
rebstastic Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make sure data types are strings 
Signed-off-by: Petra Rebernjak <petra@noom.com>
  • Loading branch information
@rebstastic
rebstastic committed Aug 30, 2022
commit 44f79e4f7898197bd1b3302d573484fa7c75a20c
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@ def get_table_column_names_and_types(
)
df = spark_session.sql(f"SELECT * FROM {self.get_table_query_string()}")
return (
(fields["name"], fields["type"])
for fields in df.schema.jsonValue()["fields"]
(field.name, field.dataType.simpleString())
for field in df.schema
)

def get_table_query_string(self) -> str:
Expand Down