Skip to content

Update Feast Core API to support Project namespacing #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
woop wants to merge 4 commits into from
Closed

Update Feast Core API to support Project namespacing #359

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6739053
Update Feast Core API to support Project namespacing
woop Dec 11, 2019
c46b892
Updated Feast Serving API to have project namespacing
woop Dec 12, 2019
c5e1bd9
Update Feast Java SDK client to support project namespacing
woop Dec 13, 2019
44a4820
Update Feast Java SDK documentation to support project namespacing
woop Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated Feast Serving API to have project namespacing 
Updated Golang SDK to Feast Serving API
  • Loading branch information
@woop
woop committed Dec 12, 2019
commit c46b8926010a8f6fa24d4f739a33a90a1333a40b
22 changes: 11 additions & 11 deletions protos/feast/serving/ServingService.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,15 @@ message GetFeastServingInfoResponse {
string job_staging_location = 10;
}

message FeatureSetRequest {
// Feature set name
string name = 1;
message FeatureReference {
// Project name
string project = 1;

// Feature set version
int32 version = 2;
// Feature name
string name = 2;

// Features that should be retrieved from this feature set
repeated string feature_names = 3;
// Feature version
int32 version = 3;

// The features will be retrieved if:
// entity_timestamp - max_age <= event_timestamp <= entity_timestamp
Expand All @@ -81,8 +81,8 @@ message FeatureSetRequest {
}

message GetOnlineFeaturesRequest {
// List of feature sets and their features that are being retrieved
repeated FeatureSetRequest feature_sets = 1;
// List of features that are being retrieved
repeated FeatureReference features = 4;

// List of entity rows, containing entity id and timestamp data.
// Used during retrieval of feature rows and for joining feature
Expand All @@ -104,8 +104,8 @@ message GetOnlineFeaturesRequest {
}

message GetBatchFeaturesRequest {
// List of feature sets and their features that are being retrieved.
repeated FeatureSetRequest feature_sets = 1;
// List of features that are being retrieved
repeated FeatureReference features = 3;

// Source of the entity dataset containing the timestamps and entity keys to retrieve
// features for.
Expand Down
2 changes: 1 addition & 1 deletion sdk/go/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ go 1.13

require (
github.com/golang/protobuf v1.3.2
github.com/google/go-cmp v0.3.0
github.com/google/go-cmp v0.3.1
github.com/opentracing/opentracing-go v1.1.0
github.com/stretchr/testify v1.4.0 // indirect
go.opencensus.io v0.22.1
Expand Down
2 changes: 2 additions & 0 deletions sdk/go/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ github.com/google/go-cmp v0.2.0 h1:+dTQ8DZQJz0Mb/HjFlkptS1FeQ4cWSnN941F8aEG4SQ=
github.com/google/go-cmp v0.2.0/go.mod h1:oXzfMopK8JAjlY9xF4vHSVASa0yLyX7SntLO5aqRK0M=
github.com/google/go-cmp v0.3.0 h1:crn/baboCvb5fXaQ0IJ1SGTsTVrWpDsCWC8EGETZijY=
github.com/google/go-cmp v0.3.0/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
github.com/google/go-cmp v0.3.1 h1:Xye71clBPdm5HgqGwUkwhbynsUJZhDbS20FvLhQ2izg=
github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
github.com/opentracing/opentracing-go v1.1.0 h1:pWlfV3Bxv7k65HYwkikxat0+s3pV4bsqf19k25Ur8rU=
github.com/opentracing/opentracing-go v1.1.0/go.mod h1:UkNAQd3GIcIGf0SeVgPpRdFStlNbqXla1AfSYxPUl2o=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
Expand Down
Loading