Skip to content

fix: Wrap LocalOutputNode return value in ArrowTableValue for consist… #6286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 2 commits into from
Apr 16, 2026
Merged

fix: Wrap LocalOutputNode return value in ArrowTableValue for consist… #6286

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a925c5f
fix: Wrap LocalOutputNode return value in ArrowTableValue for consist…
cutoutsy Apr 16, 2026
fc4729a
fix: Update test to access ArrowTableValue.data.num_rows instead of n…
cutoutsy Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Update test to access ArrowTableValue.data.num_rows instead of n… 
…um_rows

Signed-off-by: cutoutsy <cutoutsy@gmail.com>
  • Loading branch information
@cutoutsy @ntkathole
cutoutsy authored and ntkathole committed Apr 16, 2026
commit fc4729a26b995720b440fca6c4ff6d3c9d47f58b
3 changes: 2 additions & 1 deletion sdk/python/tests/unit/infra/compute_engines/local/test_nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,8 @@ def test_local_output_node():
node.add_input(MagicMock())
node.inputs[0].name = "source"
result = node.execute(context)
assert result.num_rows == 4
assert isinstance(result, ArrowTableValue)
assert result.data.num_rows == 4


def test_local_output_node_online_write_default_batch():
Expand Down
Loading