Skip to content

fix: Add project filter to apply_data_source and delete_data_source #6298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mailtoboggavarapu-coder wants to merge 7 commits into from
Closed

fix: Add project filter to apply_data_source and delete_data_source #6298

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5b34cbb
fix: Add project filter to apply_data_source and delete_data_source
mailtoboggavarapu-coder Apr 22, 2026
43faac7
test: add cross-project isolation tests for apply/delete_data_source
mailtoboggavarapu-coder Apr 22, 2026
eb71758
style: apply ruff formatting fixes to registry.py
mailtoboggavarapu-coder Apr 22, 2026
58e4a38
style: fix ruff E302 missing blank line before test function
mailtoboggavarapu-coder Apr 22, 2026
c438089
DCO Remediation Commit for 58e4a3853ba93884b7ff1eecc782e7af3f477a74
mailtoboggavarapu-coder Apr 22, 2026
528aa8f
DCO Remediation Commit for eb7175877975bbd2bc32b804d2c0c3a08613d90e
mailtoboggavarapu-coder Apr 22, 2026
163625a
Merge branch 'master' into fix/apply-data-source-project-filter
mailtoboggavarapu-coder Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: apply ruff formatting fixes to registry.py 
Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
  • Loading branch information
@mailtoboggavarapu-coder
mailtoboggavarapu-coder authored Apr 22, 2026
commit eb7175877975bbd2bc32b804d2c0c3a08613d90e
9 changes: 4 additions & 5 deletions sdk/python/feast/infra/registry/registry.py
View file
Open in desktop
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,9 @@ def apply_data_source(
return
else:
# Preserve created_timestamp from existing data source
data_source.created_timestamp = existing_data_source.created_timestamp
data_source.created_timestamp = (
existing_data_source.created_timestamp
)
del registry.data_sources[idx]
break

Expand All @@ -424,10 +426,7 @@ def delete_data_source(self, name: str, project: str, commit: bool = True):
for idx, data_source_proto in enumerate(
self.cached_registry_proto.data_sources
):
if (
data_source_proto.name == name
and data_source_proto.project == project
):
if data_source_proto.name == name and data_source_proto.project == project:
del self.cached_registry_proto.data_sources[idx]
if commit:
self.commit()
Expand Down