Skip to content

feat: Support non-string map key types (#6382) #6383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nquinn408 merged 4 commits into from
May 8, 2026
Merged

feat: Support non-string map key types (#6382) #6383

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50cf399
feat: Support non-string map key types (#6382)
nickquinn408 May 7, 2026
63b8732
Fix test
nickquinn408 May 7, 2026
2422388
Fixing linter issue
nickquinn408 May 7, 2026
b7aaace
Bounding prometheus client version
nickquinn408 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test 
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
  • Loading branch information
@nickquinn408
nickquinn408 committed May 7, 2026
commit 63b87321f822d068ce5d9c4c31a422a39828159c
5 changes: 5 additions & 0 deletions sdk/python/feast/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"UNIX_TIMESTAMP": "UNIX_TIMESTAMP",
"MAP": "MAP",
"JSON": "JSON",
"SCALAR_MAP": "SCALAR_MAP",
}


Expand Down Expand Up @@ -93,6 +94,7 @@ class PrimitiveFeastType(Enum):
UUID = 13
TIME_UUID = 14
DECIMAL = 15
SCALAR_MAP = 16

def to_value_type(self) -> ValueType:
"""
Expand Down Expand Up @@ -130,6 +132,7 @@ def __hash__(self):
Uuid = PrimitiveFeastType.UUID
TimeUuid = PrimitiveFeastType.TIME_UUID
Decimal = PrimitiveFeastType.DECIMAL
ScalarMap = PrimitiveFeastType.SCALAR_MAP

SUPPORTED_BASE_TYPES = [
Invalid,
Expand Down Expand Up @@ -167,6 +170,7 @@ def __hash__(self):
"UUID": "Uuid",
"TIME_UUID": "TimeUuid",
"DECIMAL": "Decimal",
"SCALAR_MAP": "ScalarMap",
}


Expand Down Expand Up @@ -346,6 +350,7 @@ def __hash__(self):
ValueType.DECIMAL: Decimal,
ValueType.DECIMAL_LIST: Array(Decimal),
ValueType.DECIMAL_SET: Set(Decimal),
ValueType.SCALAR_MAP: ScalarMap,
}

FEAST_TYPES_TO_PYARROW_TYPES = {
Expand Down
Loading