Skip to content

FIX identityChange service all#176

Closed
gmercey wants to merge 1 commit into
feathersjs-ecosystem:masterfrom
gmercey:patch-1
Closed

FIX identityChange service all#176
gmercey wants to merge 1 commit into
feathersjs-ecosystem:masterfrom
gmercey:patch-1

Conversation

@gmercey

@gmercey gmercey commented Jun 6, 2022

Copy link
Copy Markdown

The passwordField params is pass as 5th params to the identityChange method which DOES NOT expected this param. Instead it is overriding the notifierOptions params and makes it impossible to pass notifier option to the call.

The `passwordField` params is pass as 5th params to the `identityChange` method which DOES NOT expected this param. Instead it is overriding the `notifierOptions` params and makes it impossible to pass notifier option to the call.
@fratzinger

Copy link
Copy Markdown
Collaborator

Thanks for the catch! I also found this and included it in the new pre version (see #164).

This will be fixed in the new pre version, but it is a valid option that can be overwritten by the options (see https://feathers-a-m.netlify.app/configuration.html#service-options).

I have to catch up with the latest changes to the js version. Could you please try out npm install feathers-authentication-management@4.0.0-pre.1 and see if it works (Migration Guide). That would be super helpful to get feedback.

@gmercey

gmercey commented Jun 7, 2022

Copy link
Copy Markdown
Author

I'm on a tight schedule for a release, but I will to the pre version ASAP. Thanks!

@fratzinger

Copy link
Copy Markdown
Collaborator

I released the typescript version as feathers-authentication-management@4.0.0.
Thanks again @gmercey for the PR! I think this should be fixed in the new typescript version. So I will close this PR. If you encounter any problems please let me know.

@fratzinger fratzinger closed this Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants