Skip to content

Include required in pagination result#254

Merged
Mairu merged 1 commit into
feathersjs-ecosystem:masterfrom
AshotN:master
Dec 26, 2023
Merged

Include required in pagination result#254
Mairu merged 1 commit into
feathersjs-ecosystem:masterfrom
AshotN:master

Conversation

@AshotN

@AshotN AshotN commented Aug 20, 2023

Copy link
Copy Markdown
Contributor

Summary

I was using https://github.com/acacode/swagger-typescript-api to generate a TypeScript client based on the swagger file created by feathers-swagger and one issue I ran across is that pagination results had all optional properties.

Like this

/** Company pagination result */
export interface CompanyPaginationType {
  total?: number;
  limit?: number;
  skip?: number;
  data?: CompanyListType;
}

I believe this is not correct, so this PR address that and the outputted type looks like this now

/** Company pagination result */
export interface CompanyPaginationType {
  total: number;
  limit: number;
  skip: number;
  data: CompanyListType;
}

@AshotN AshotN mentioned this pull request Dec 25, 2023
Open
@Mairu Mairu merged commit 589ba49 into feathersjs-ecosystem:master Dec 26, 2023
Mairu added a commit that referenced this pull request Dec 26, 2023
@Mairu
fix(tests): fix tests after merge of #254
0aa8a94 
- chore: update dependencies and adjust tests
- fix: fix path of local js files for documentation
- ci: add node 20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AshotN @Mairu