Skip to content

Skip Anchored and derived features if the feature data is unavailable#1026

Merged
rakeshkashyap123 merged 9 commits into
mainfrom
anchoredFeaturesSkip
Feb 3, 2023
Merged

Skip Anchored and derived features if the feature data is unavailable#1026
rakeshkashyap123 merged 9 commits into
mainfrom
anchoredFeaturesSkip

Conversation

@rakeshkashyap123

@rakeshkashyap123 rakeshkashyap123 commented Feb 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  1. If the feature data is unavailable and the skip missing feature flag is turned on, skip adding the anchored and derived features.
  2. Similar functionality has been implemented already - Skip features optionally if feature data is missing #1019

@rakeshkashyap123 rakeshkashyap123 changed the title Skip Anchored features if the feature data is unavailable Skip Anchored and derived features if the feature data is unavailable Feb 1, 2023
bozhonghu
bozhonghu reviewed Feb 2, 2023
View reviewed changes
Comment thread feathr-impl/src/main/scala/com/linkedin/feathr/offline/client/FeathrClient.scala Outdated
bozhonghu
bozhonghu previously approved these changes Feb 2, 2023
View reviewed changes

@bozhonghu bozhonghu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a minor documentation comment

@xiaoyongzhu xiaoyongzhu added the safe to test Tag to execute build pipeline for a PR from forked repo label Feb 3, 2023
Rakesh Kashyap Hanasoge Padmanabha added 2 commits February 3, 2023 00:52
bozhonghu
bozhonghu approved these changes Feb 3, 2023
View reviewed changes

@bozhonghu bozhonghu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rakeshkashyap123 rakeshkashyap123 merged commit c995de5 into main Feb 3, 2023
@rakeshkashyap123 rakeshkashyap123 mentioned this pull request Feb 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bozhonghu bozhonghu bozhonghu approved these changes

@jaymo001 jaymo001 jaymo001 approved these changes

Assignees

No one assigned

Labels

safe to test Tag to execute build pipeline for a PR from forked repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rakeshkashyap123 @bozhonghu @jaymo001 @xiaoyongzhu