[web-console] Fix pipeline health details UI doesn't display some fields#6362
Merged
Conversation
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
mythical-fred
approved these changes
Jun 1, 2026
mythical-fred
left a comment
mythical-fred
left a comment
There was a problem hiding this comment.
Web-console fix for #6272. Two files, tight scope:
formatStatusWithDesiredadds the "(desired is X)" suffix only when the desired value is non-null and differs from the current — covers the no-mismatch, mismatch, and nullish-desired cases.storage_status+storage_status_detailsare now rendered in the event description (the original bug: these fields were missing from the pretty-printed health details).- Tests cover all four shapes (full event, suffix omitted when equal, suffix appended when different, suffix omitted when desired is nullish) and the new
storage_status_detailsJSON block.
The format helper does String(desired) === String(current) for the equality check, which handles the common case correctly but would still suppress the suffix if e.g. both are coerced to "[object Object]". Given the field types in PipelineMonitorEventSelectedInfo are enum strings or nullable, this is fine in practice — non-blocking.
LGTM.
mihaibudiu
approved these changes
Jun 1, 2026
snkas
approved these changes
Jun 1, 2026
| it('renders status detail blocks as pretty JSON when provided', () => { | ||
| const out = formatPipelineEventDescription( | ||
| makeEvent({ | ||
| storage_status_details: { backend: 'file' }, |
| expect(out).toContain('storage_status: (none)') | ||
| expect(out).toContain('deployment_resources_status: Stopped') | ||
| expect(out).toContain('deployment_runtime_status: (none)') | ||
| expect(out).not.toContain('desired is') |
Contributor
There was a problem hiding this comment.
Are these tests or assertions?
Contributor
Author
There was a problem hiding this comment.
Assertions for individual fields expected to be in the pretty-printed text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: manual, extended unit test
Fix #6272