pipeline-manager: rust compilation cleans up target#6410
Merged
Conversation
gz
approved these changes
Jun 5, 2026
mihaibudiu
approved these changes
Jun 5, 2026
Contributor
Author
It'll need some more downstream testing before I merge this PR. Restarting is the same as it temporarily going down (it goes through continuous cycle of |
snkas
force-pushed
the
compiler-cleanup
branch
2 times, most recently
from
ca76503 to
627be02
Compare
Contributor
Author
|
A future work is adding compiler server remaining disk space to its health check. |
Contributor
Author
|
CI run: #6410 |
Contributor
Author
The Rust compilation cleanup now checks whether the disk on which it takes place it about to reach a usage threshold: - If it exceeds 70%, a warning is printed. - If it exceeds 90%, the `target` directory is removed if it is 5% or more of the total disk space. The compiler server is restarted if the form factor supports it. The OSS edition form factor does not support this restart behavior, and as such it will mean that it will need to recompile from scratch. A warning is printed to inform of this, as an indication to increase the disk size. This behavior is currently gated behind the unstable feature `rust_compiler_full_cleanup`, and thus needs to be explicitly activated. Signed-off-by: Simon Kassing <simon.kassing@feldera.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust compilation cleanup now checks whether the disk on which it takes place it about to reach a usage threshold:
targetdirectory is removed if it is 5% or more of the total disk space. The compiler server is restarted if the form factor supports it. The OSS edition form factor does not support this restart behavior, and as such it will mean that it will need to recompile from scratch. A warning is printed to inform of this, as an indication to increase the disk size.This behavior is currently gated behind the unstable feature
rust_compiler_full_cleanup, and thus needs to be explicitly activated.PR information