[SLT] Skip tests with ambiguous queries#6457
Merged
Merged
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mythical-fred
approved these changes
Jun 12, 2026
mythical-fred
left a comment
mythical-fred
left a comment
There was a problem hiding this comment.
APPROVE — skip-list addition only; both queries are ambiguous GROUP BY ... HAVING with duplicate output aliases (col2, col1) over an unaggregated column, which Calcite 1.42's tightened validator now flags correctly. Postgres rejects them too, so the skip is the right call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove two queries which Postgres also rejects as ambiguous. I guess that the Calcite validator has become a bit more strict since the last time we ran these queries?
Describe Manual Test Plan
Ran all the SLT tests which were not executed overnight.