Index out of bounds in PhaseDiagram.binary_vle() fixed.#362
Open
RolfStierle wants to merge 3 commits into
Open
Index out of bounds in PhaseDiagram.binary_vle() fixed.#362RolfStierle wants to merge 3 commits into
RolfStierle wants to merge 3 commits into
Conversation
Contributor
|
Thanks for the fix, this algorithm to find heteroazeotropes is a bit crude. I guess here it failed, because there was some non-convergence at the point where the dew lines cross? In any case important to fix it now and then maybe have a closer look at some point. We can also directly go for a patch release? Agreed @g-bauer ? |
prehner
approved these changes
Jul 3, 2026
Contributor
|
Fine for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Index correction that only valid array elements are accessed as described in #361 .