Migrate firebase-crashlytics SDK to FIS#1760
Merged
Merged
Conversation
Collaborator
Coverage ReportAffected SDKsNo changes between base commit (be99c93) and head commit (96267bbf). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (96267bbf) is created by Prow via merging commits: be99c93 2061b2d. |
Collaborator
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (96267bbf) is created by Prow via merging commits: be99c93 2061b2d. |
mrwillis21
approved these changes
Jul 7, 2020
mrwillis21
left a comment
mrwillis21
left a comment
Contributor
There was a problem hiding this comment.
A couple of minor requests, but otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.