Skip to content

fix undefined URL issues#2818

Merged
bkendall merged 3 commits into
masterfrom
bk-2817
Nov 13, 2020
Merged

fix undefined URL issues#2818
bkendall merged 3 commits into
masterfrom
bk-2817

Conversation

@bkendall

Copy link
Copy Markdown
Contributor

Description

Fixes #2817

URL is not a global in Node 8 and must be imported.

Scenarios Tested

Downloading emulators on Node 8 environments works now. So does database:settings:get.

@bkendall bkendall requested a review from samtstern November 13, 2020 17:00
@google-cla google-cla Bot added the cla: yes Manual indication that this has passed CLA. label Nov 13, 2020
@bkendall bkendall merged commit 0e5f443 into master Nov 13, 2020
@bkendall bkendall deleted the bk-2817 branch November 13, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReferenceError: URL is not defined when downloading emulator in CircleCi with v8.16.0 & v8.16.1

2 participants