Fix port conflicts with functions:shell#3223
Merged
Merged
Conversation
joehan
approved these changes
Mar 22, 2021
joehan
left a comment
joehan
left a comment
Member
There was a problem hiding this comment.
LGTM after a few tiny cleanups + lodash removal.
| var initializeContext = function (context) { | ||
| _.forEach(emulator.triggers, function (trigger) { | ||
| const initializeContext = (context: any) => { | ||
| _.forEach(emulator.triggers, (trigger) => { |
Member
There was a problem hiding this comment.
Optional - it would be pretty easy to refactor this chunk to use plain JS instead of lodash, and then we're one step closer to removing the dependency for good
Contributor
Author
There was a problem hiding this comment.
I got rid of _.forEach and _.includes but _.set with dot-separated path notation is a bit tricky so I left that. We'll probably need to create our own utils.set to replace that throughout the codebase and that seems out of scope for this PR.
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3210
Also I converted the file to
.tswhile I was in thereScenarios Tested
firebase.json--portflagSample Commands
N/A