Skip to content

[firebase_analytics] Endorse web implementation.#2865

Merged
kroikie merged 2 commits into
firebase:masterfrom
ditman:endorse-analytics-web
Jun 30, 2020
Merged

[firebase_analytics] Endorse web implementation.#2865
kroikie merged 2 commits into
firebase:masterfrom
ditman:endorse-analytics-web

Conversation

@ditman

@ditman ditman commented Jun 30, 2020

Copy link
Copy Markdown
Contributor

Description

This change is the second attempt at endorsing firebase_analytics_web as the default implementation for web of firebase_analytics.

It also adds support for web to the example app (modify index.html with your project config and run flutter run -d chrome)

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

* Also: add web support to example app.
@ditman

ditman commented Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

/cc @tugorez

@tugorez

tugorez commented Jun 30, 2020

Copy link
Copy Markdown
Contributor

FYI this PR will also fix #2802.

@ditman

ditman commented Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

FYI this PR will also fix #2802.

Thanks @tugorez, I added it to the description of the PR!

@kroikie kroikie merged commit 1daaea7 into firebase:master Jun 30, 2020
@ditman ditman deleted the endorse-analytics-web branch June 30, 2020 22:41
@ditman

ditman commented Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

Tagged and published firebase_analytics 5.0.16

@firebase firebase locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firebase Analytics for Web wrong Readme [firebase_analytics] Support firebase_analytics on web.

4 participants