docs: add application security review findings#6
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: quan.m.le <quan.m.le@opswat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
SECURITY_REVIEW_FINDINGS.mdfrom the scheduled application security review at commit58cd0b8df278d1932dac036e3ea93c16d1a7aaa6.New finding (Medium): Permission model bypass via pre-existing symlinks in
src/node_file.cc— lexical path checks allow reads/writes through symlinks planted in allowlisted directories.Remediation direction
Resolve paths with
realpathbefore permission checks, or reject opens when the resolved target lies outside the granted tree.