Added min and max validation to dateTime and datePicker directives#103
Merged
Conversation
added 3 commits
April 21, 2015 10:05
…ation was added. The user can still choose an invalid date)
…note: only validation was added. The user can still choose an invalid date)
Collaborator
|
Is it working as intended? http://plnkr.co/edit/2mVdDodovYhJGILRPrAZ?p=preview my input field is updating and i have set the min value. |
Collaborator
|
Ok i have read the note: (only validation was added...) |
eralha
added a commit
that referenced
this pull request
Apr 22, 2015
Added min and max validation to dateTime and datePicker directives
Author
|
@eralha Yeah, only validation. That was all I needed for my project, at least for now. If you implement the restraint though, that would be very nice. |
Collaborator
|
it invalidate the ngModel, so i think that will be enough for most cases, if some one request the restraint feature i will implement it, for now its good as it is :) thanks for the colaboration! |
Author
|
My pleasure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote the function in the correct location and did the grunt build as requested by @eralha.