Adjust publications to publish gradle module metadata#3422
Merged
Conversation
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7ca9895 | 364.31 ms | 460.46 ms | 96.15 ms |
| bf82eb3 | 423.76 ms | 506.45 ms | 82.69 ms |
| d429384 | 397.33 ms | 457.69 ms | 60.36 ms |
| f5e1b97 | 362.53 ms | 429.31 ms | 66.78 ms |
| c554ca2 | 368.52 ms | 430.74 ms | 62.22 ms |
| 9119d59 | 407.12 ms | 509.64 ms | 102.52 ms |
| a33b076 | 381.94 ms | 459.64 ms | 77.71 ms |
| 93a76ca | 397.30 ms | 455.16 ms | 57.87 ms |
| 283d83e | 348.44 ms | 392.06 ms | 43.62 ms |
| 9e57f46 | 368.94 ms | 410.50 ms | 41.56 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7ca9895 | 1.72 MiB | 2.29 MiB | 576.51 KiB |
| bf82eb3 | 1.70 MiB | 2.28 MiB | 587.99 KiB |
| d429384 | 1.72 MiB | 2.27 MiB | 558.42 KiB |
| f5e1b97 | 1.70 MiB | 2.28 MiB | 592.00 KiB |
| c554ca2 | 1.70 MiB | 2.27 MiB | 582.25 KiB |
| 9119d59 | 1.70 MiB | 2.27 MiB | 583.84 KiB |
| a33b076 | 1.70 MiB | 2.28 MiB | 592.32 KiB |
| 93a76ca | 1.72 MiB | 2.29 MiB | 576.75 KiB |
| 283d83e | 1.72 MiB | 2.29 MiB | 577.69 KiB |
| 9e57f46 | 1.70 MiB | 2.28 MiB | 592.08 KiB |
Previous results on branch: rz/fix/publications
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| df921fc | 424.75 ms | 495.76 ms | 71.01 ms |
| e164c0d | 472.90 ms | 569.70 ms | 96.80 ms |
| 3268987 | 411.21 ms | 491.78 ms | 80.57 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| df921fc | 1.70 MiB | 2.28 MiB | 592.11 KiB |
| e164c0d | 1.70 MiB | 2.28 MiB | 592.08 KiB |
| 3268987 | 1.70 MiB | 2.28 MiB | 592.11 KiB |
romtsn
force-pushed
the
rz/fix/publications
branch
from
cee0ad5 to
25dadc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.modulefiles into the final dist.zip, so they are ready to be published by craftsentry-compose-helperacompileOnlydependency, so it doesn't get added to the .pom and .module filesimplementationfor the modules that are usingsentry-compose. Our customers are still fine though, as we embed the classes from the-helpermodule and it's published to maven like thatRelevant PR in craft: getsentry/craft#535
Closes #2233