Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
7f8f892
feat(otel): Autoinstrumentation skeleton
sentrivana Jun 7, 2024
766b216
Merge branch 'master' into ivana/potel/autoinstrumentation
sentrivana Jun 7, 2024
cd78db4
Merge branch 'master' into ivana/potel/autoinstrumentation
sentrivana Jun 10, 2024
f45dd83
install otel for linting
sentrivana Jun 10, 2024
21d3084
type: ingores
sentrivana Jun 10, 2024
c8a3660
more mypy
sentrivana Jun 10, 2024
363b203
add otel experimental test target
sentrivana Jun 10, 2024
06f9070
change target name
sentrivana Jun 10, 2024
72bd975
rename everywhere maybe
sentrivana Jun 10, 2024
952aad2
rename everywhere maybe
sentrivana Jun 10, 2024
61d17e8
more testing
sentrivana Jun 10, 2024
7a8155b
fix tests
sentrivana Jun 10, 2024
6c76f3e
more potel tests
sentrivana Jun 13, 2024
6e3b4d2
Merge branch 'master' into ivana/potel/autoinstrumentation
sentrivana Jun 13, 2024
a1c79c9
no flask, fastapi with regular otel setup
sentrivana Jun 13, 2024
e328f5b
fix py versions
sentrivana Jun 13, 2024
ea66806
Merge branch 'master' into ivana/potel/autoinstrumentation
sentrivana Jun 19, 2024
83433a2
Set up typing for otel
sentrivana Jun 13, 2024
219c222
remove type: ignore
sentrivana Jun 17, 2024
2da7c80
mypy fixes
sentrivana Jun 18, 2024
2e91fbb
more mypy fixes
sentrivana Jun 19, 2024
cb2e19a
fixes
sentrivana Jun 19, 2024
7d7a2b7
weird but ok
sentrivana Jun 19, 2024
fe6f2d2
Merge branch 'master' into ivana/potel/autoinstrumentation
sentrivana Jun 20, 2024
73ccfed
Merge branch 'ivana/potel/autoinstrumentation' into ivana/potel/typing
sentrivana Jun 20, 2024
23b1fe8
remove extra cast, fix another
sentrivana Jun 21, 2024
4a4ca4a
fix no parent_context
sentrivana Jun 21, 2024
adf01b4
Merge branch 'master' into ivana/potel/typing
sentrivana Jun 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements-linting.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ types-greenlet
types-redis
types-setuptools
types-webob
opentelemetry-distro
pymongo # There is no separate types module.
loguru # There is no separate types module.
flake8-bugbear
Expand Down
5 changes: 2 additions & 3 deletions sentry_sdk/integrations/opentelemetry/consts.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
from opentelemetry.context import ( # type: ignore
create_key,
)
from opentelemetry.context import create_key


SENTRY_TRACE_KEY = create_key("sentry-trace")
SENTRY_BAGGAGE_KEY = create_key("sentry-baggage")
8 changes: 4 additions & 4 deletions sentry_sdk/integrations/opentelemetry/distro.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
from sentry_sdk._types import TYPE_CHECKING

try:
from opentelemetry import trace # type: ignore
from opentelemetry.instrumentation.distro import BaseDistro # type: ignore
from opentelemetry.propagate import set_global_textmap # type: ignore
from opentelemetry.sdk.trace import TracerProvider # type: ignore
from opentelemetry import trace
from opentelemetry.instrumentation.distro import BaseDistro # type: ignore[attr-defined]
from opentelemetry.propagate import set_global_textmap
from opentelemetry.sdk.trace import TracerProvider
except ImportError:
raise DidNotEnable("opentelemetry not installed")

Expand Down
2 changes: 1 addition & 1 deletion sentry_sdk/integrations/opentelemetry/integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from sentry_sdk._types import TYPE_CHECKING

try:
from opentelemetry.instrumentation.auto_instrumentation._load import ( # type: ignore
from opentelemetry.instrumentation.auto_instrumentation._load import (
_load_instrumentors,
)
except ImportError:
Expand Down
14 changes: 7 additions & 7 deletions sentry_sdk/integrations/opentelemetry/propagator.py
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
from opentelemetry import trace # type: ignore
from opentelemetry.context import ( # type: ignore
from opentelemetry import trace
from opentelemetry.context import (
Context,
get_current,
set_value,
)
from opentelemetry.propagators.textmap import ( # type: ignore
from opentelemetry.propagators.textmap import (
CarrierT,
Getter,
Setter,
TextMapPropagator,
default_getter,
default_setter,
)
from opentelemetry.trace import ( # type: ignore
from opentelemetry.trace import (
NonRecordingSpan,
SpanContext,
TraceFlags,
Expand All @@ -37,13 +37,13 @@
from typing import Set


class SentryPropagator(TextMapPropagator): # type: ignore
class SentryPropagator(TextMapPropagator):
"""
Propagates tracing headers for Sentry's tracing system in a way OTel understands.
"""

def extract(self, carrier, context=None, getter=default_getter):
# type: (CarrierT, Optional[Context], Getter) -> Context
# type: (CarrierT, Optional[Context], Getter[CarrierT]) -> Context
if context is None:
context = get_current()

Expand Down Expand Up @@ -85,7 +85,7 @@ def extract(self, carrier, context=None, getter=default_getter):
return modified_context

def inject(self, carrier, context=None, setter=default_setter):
# type: (CarrierT, Optional[Context], Setter) -> None
# type: (CarrierT, Optional[Context], Setter[CarrierT]) -> None
if context is None:
context = get_current()

Expand Down
Loading