fix: mask sensitive authentication tokens in console output#1558
Open
Abzaek wants to merge 1 commit into
Open
Conversation
runBridgeAuthShow prints token values in plain text. This exposes sensitive credentials to anyone with access to terminal output or logs. Fix: mask the token by showing only the first and last 4 characters, replacing the middle with asterisks (e.g., abcd****wxyz). Fixes git-bug#1545
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1545
The runBridgeAuthShow function prints authentication token values in plain text. This exposes sensitive credentials to anyone with access to terminal output or logs.
Fix: mask the token by showing only the first and last 4 characters, replacing the middle with asterisks (e.g., "abcd****wxyz" for a 12-character token). Short tokens are left unmasked to avoid ambiguity.