Use separate buildType and productFlavors for determining the json locations#131
Closed
ChristianKatzmann wants to merge 1 commit into
Closed
Use separate buildType and productFlavors for determining the json locations#131ChristianKatzmann wants to merge 1 commit into
ChristianKatzmann wants to merge 1 commit into
Conversation
Author
|
Anything I can do to get this PR merged? |
|
@ChristianBecker A lot of waiting apparently 🤔 |
Author
|
@jkasnicki @caller9 @aaronj1335 Friendly ping. This "bug" makes the plugin unusable for me :( |
Author
|
@caller9 Any chance you can eventually get this PR reviewed and merged? I still can't use the release version of this plugin 👎 |
Collaborator
|
Another team works on this plugin and they're taking a look. If you could update with the latest changes from |
Author
|
@caller9 Thanks for forwarding this request 👍 I just rebased against latest |
davidmotson
pushed a commit
that referenced
this pull request
Apr 29, 2021
Contributor
|
This was merged in #149 |
Author
|
@davidmotson Thank you! Do you plan to release a new version with this fix? |
Contributor
|
it is now released in 4.3.6 |
why it is not closed then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a project with two dimensions. The brands are named in
lowerCamelCase, so I may have an uppercase character in the name of the brand.Unfortunately, the current version of the Play Services Plugin does not work with those names, as we split the
variant.dirNameby uppercase characters to get all different flavors – which is not correct in my situation.I refactored the
GoogleServicesTaskto use the names of the existing fieldsbuildTypeandproductFlavors. Using this approach, we don't have to use regular expressions at all.