fix(storage): Add telemetry tracing support for async stream Close()#16118
Merged
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements the Close method override in AsyncWriterConnectionTracing to enable OpenTelemetry tracing for close operations. It captures metadata such as message type, message ID, thread ID, and payload size, and logs a "gl-cpp.close" event. Additionally, corresponding unit tests (Close and CloseError) have been added to verify successful and failed close operations and their tracing events. I have no feedback to provide as there are no review comments.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16118 +/- ##
==========================================
- Coverage 92.72% 92.71% -0.02%
==========================================
Files 2356 2356
Lines 220517 220557 +40
==========================================
+ Hits 204468 204482 +14
- Misses 16049 16075 +26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
v-pratap
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces OpenTelemetry tracing support for the newly introduced GCS Close() operation in the connection wrapper, ensuring end-to-end observability on connection half-close teardowns. This is a follow-up to #16112.