This repository was archived by the owner on May 8, 2026. It is now read-only.
chore: refactor unary callable chains to avoid code duplication#2394
Merged
Conversation
Change-Id: Idbb2727108857daa662f2e4690053cb6065ad054
Change-Id: I22910ebd8024eecf623fee595596fa53e4ec59f5
product-auto-label
Bot
added
size: l
igorbernstein2
changed the title
This reverts commit d743e4b.
igorbernstein2
added
the
automerge
mutianf
suggested changes
Nov 4, 2024
mutianf
left a comment
mutianf
left a comment
Contributor
There was a problem hiding this comment.
Can we add the unary tests to EnhancedBigtableStubTest?
Change-Id: I02d2e06e5c93cf5157d26389a7a41ff53cef7ea9
Change-Id: I0ae44d5d286fae4209dedc89f09eb30fde22af24
mutianf
approved these changes
Nov 4, 2024
Change-Id: Ia7af9eaab0f957129354d896d36643665d5703ac
|
Your PR has conflicts that you need to resolve before merge-on-green can automerge |
Change-Id: I644d73fc85c3af024667d0faa3a5a99cbf497c75 # Conflicts: # google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is primarily a code clean up change that extracts all of the unary chain building logic into a helper method and removes a significant amount of code duplication.