Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

feat: update Nodejs generator to send API versions in headers for GAPICs#1919

Merged
gcf-merge-on-green[bot] merged 3 commits into
mainfrom
owl-bot-copy
May 23, 2024
Merged

feat: update Nodejs generator to send API versions in headers for GAPICs#1919
gcf-merge-on-green[bot] merged 3 commits into
mainfrom
owl-bot-copy

Conversation

@gcf-owl-bot

@gcf-owl-bot gcf-owl-bot Bot commented May 8, 2024 •
edited by feywind
Loading

Copy link
Copy Markdown
Contributor
  • Regenerate this pull request now.

PiperOrigin-RevId: 634109303

Source-Link: googleapis/googleapis@998ade8

Source-Link: https://github.com/googleapis/googleapis-gen/commit/000ca6f00801f65b847e6029cb05111404df21ec
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDAwY2E2ZjAwODAxZjY1Yjg0N2U2MDI5Y2IwNTExMTQwNGRmMjFlYyJ9

fix: An existing method UpdateVehicleLocation is removed from service VehicleService
fix: An existing method SearchFuzzedVehicles is removed from service VehicleService
fix: An existing message UpdateVehicleLocationRequest is removed

PiperOrigin-RevId: 631557549

Source-Link: googleapis/googleapis@3d50414

Source-Link: https://github.com/googleapis/googleapis-gen/commit/5ce63d4e636a975175bde2d16c15e70dd5a81ff4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWNlNjNkNGU2MzZhOTc1MTc1YmRlMmQxNmMxNWU3MGRkNWE4MWZmNCJ9

Remove the "breaking" from this change, since it doesn't affect us:

BEGIN_COMMIT_OVERRIDE
fix: An existing method UpdateVehicleLocation is removed from service VehicleService
fix: An existing method SearchFuzzedVehicles is removed from service VehicleService
fix: An existing message UpdateVehicleLocationRequest is removed
END_COMMIT_OVERRIDE

@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 8, 2024
@product-auto-label product-auto-label Bot added the size: xl Pull request size is extra large. label May 8, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 8, 2024
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label May 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2024
@gcf-owl-bot gcf-owl-bot Bot marked this pull request as ready for review May 8, 2024 03:02
@gcf-owl-bot gcf-owl-bot Bot requested review from a team May 8, 2024 03:02
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 8, 2024
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xl Pull request size is extra large. labels May 8, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2024
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels May 8, 2024
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 8, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2024
@gcf-owl-bot gcf-owl-bot Bot changed the title fix!: An existing method UpdateVehicleLocation is removed from service VehicleService feat: update Nodejs generator to send API versions in headers for GAPICs May 16, 2024
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: xs Pull request size is extra small. labels May 16, 2024
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 16, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@feywind feywind added the automerge Merge the pull request once unit tests and other checks pass. label May 23, 2024
@gcf-owl-bot

gcf-owl-bot Bot commented May 23, 2024

Copy link
Copy Markdown
Contributor Author

Owl bot is regenerating pull request 1919...
Build name: YmU0OGIyMDItMjA2Yi00YmYzLTlhM2UtNDJiMmIwMjAyMDk0

@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 23, 2024
@feywind feywind removed kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 23, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@feywind feywind added owlbot:ignore instruct owl-bot to ignore a PR owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels May 23, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 23, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: xs Pull request size is extra small. labels May 23, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 23, 2024
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 23, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 23, 2024
@feywind

feywind commented May 23, 2024

Copy link
Copy Markdown
Collaborator

There's a problem with the sample formatting, probably due to OwlBot typeless doc shenanigans; don't merge yet.

@gcf-owl-bot

gcf-owl-bot Bot commented May 23, 2024

Copy link
Copy Markdown
Contributor Author

Owl bot is regenerating pull request 1919...
Build name: NzQzNjNiMGYtY2Q2OS00ZjI4LWE4NjItZWE3MDhjZjFjOWVh

feywind
feywind approved these changes May 23, 2024
View reviewed changes

@feywind feywind left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approve

gcf-owl-bot Bot added 3 commits May 23, 2024 21:15
@gcf-owl-bot
feat: update Nodejs generator to send API versions in headers for GAPICs
d8c80f8 
PiperOrigin-RevId: 634109303

Source-Link: googleapis/googleapis@998ade8

Source-Link: googleapis/googleapis-gen@000ca6f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDAwY2E2ZjAwODAxZjY1Yjg0N2U2MDI5Y2IwNTExMTQwNGRmMjFlYyJ9

fix!: An existing method `UpdateVehicleLocation` is removed from service `VehicleService`
fix!: An existing method `SearchFuzzedVehicles` is removed from service `VehicleService`
fix!: An existing message `UpdateVehicleLocationRequest` is removed

PiperOrigin-RevId: 631557549

Source-Link: googleapis/googleapis@3d50414

Source-Link: googleapis/googleapis-gen@5ce63d4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWNlNjNkNGU2MzZhOTc1MTc1YmRlMmQxNmMxNWU3MGRkNWE4MWZmNCJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
44cec52 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
98077f3 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@release-please release-please Bot mentioned this pull request May 23, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@feywind feywind feywind approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. owl-bot-copy size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@feywind @yoshi-kokoro