Skip to content

A more efficient PropertyDataFetcher #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 1 commit into from
May 21, 2020
Merged

A more efficient PropertyDataFetcher #1815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 35 additions & 18 deletions src/main/java/graphql/schema/PropertyDataFetcherHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.function.Predicate;

import static graphql.Assert.assertShouldNeverHappen;
import static graphql.Scalars.GraphQLBoolean;
import static graphql.schema.GraphQLTypeUtil.isNonNull;
import static graphql.schema.GraphQLTypeUtil.unwrapOne;
Expand Down Expand Up @@ -45,15 +46,42 @@ public static Object getPropertyValue(String propertyName, Object object, GraphQ
}

String key = mkKey(object, propertyName);
//
// if we have tried all strategies before and they have all failed then we negatively cache
// the key and assume that its never going to turn up. This shortcuts the property lookup
// in systems where there was a `foo` graphql property but they never provided an POJO
// version of `foo`.
if (isNegativelyCached(key)) {
return null;
}
// lets try positive cache mechanisms next. If we have seen the method or field before
// then we invoke it directly without burning any cycles doing reflection.
Method cachedMethod = METHOD_CACHE.get(key);
if (cachedMethod != null) {
MethodFinder methodFinder = (aClass, methodName) -> cachedMethod;
try {
return getPropertyViaGetterMethod(object, propertyName, graphQLType, methodFinder, environment);
} catch (NoSuchMethodException ignored) {
assertShouldNeverHappen("A method cached as '%s' is no longer available??", key);
}
}
Field cachedField = FIELD_CACHE.get(key);
if (cachedField != null) {
try {
return getPropertyViaFieldAccess(object, propertyName);
} catch (FastNoSuchMethodException ignored) {
assertShouldNeverHappen("A field cached as '%s' is no longer available??", key);
}
}

boolean dfeInUse = environment != null;
try {
return getPropertyViaGetterMethod(object, propertyName, graphQLType, (root, methodName) -> findPubliclyAccessibleMethod(propertyName, root, methodName, dfeInUse), environment);
MethodFinder methodFinder = (root, methodName) -> findPubliclyAccessibleMethod(propertyName, root, methodName, dfeInUse);
return getPropertyViaGetterMethod(object, propertyName, graphQLType, methodFinder, environment);
} catch (NoSuchMethodException ignored) {
try {
return getPropertyViaGetterMethod(object, propertyName, graphQLType, (aClass, methodName) -> findViaSetAccessible(propertyName, aClass, methodName, dfeInUse), environment);
MethodFinder methodFinder = (aClass, methodName) -> findViaSetAccessible(propertyName, aClass, methodName, dfeInUse);
return getPropertyViaGetterMethod(object, propertyName, graphQLType, methodFinder, environment);
} catch (NoSuchMethodException ignored2) {
try {
return getPropertyViaFieldAccess(object, propertyName);
Expand Down Expand Up @@ -125,16 +153,12 @@ private static Method findPubliclyAccessibleMethod(String propertyName, Class<?>
Class<?> currentClass = root;
while (currentClass != null) {
String key = mkKey(currentClass, propertyName);
Method method = METHOD_CACHE.get(key);
if (method != null) {
return method;
}
if (Modifier.isPublic(currentClass.getModifiers())) {
if (dfeInUse) {
//
// try a getter that takes DataFetchingEnvironment first (if we have one)
try {
method = currentClass.getMethod(methodName, DataFetchingEnvironment.class);
Method method = currentClass.getMethod(methodName, DataFetchingEnvironment.class);
if (Modifier.isPublic(method.getModifiers())) {
METHOD_CACHE.putIfAbsent(key, method);
return method;
Expand All @@ -143,7 +167,7 @@ private static Method findPubliclyAccessibleMethod(String propertyName, Class<?>
// ok try the next approach
}
}
method = currentClass.getMethod(methodName);
Method method = currentClass.getMethod(methodName);
if (Modifier.isPublic(method.getModifiers())) {
METHOD_CACHE.putIfAbsent(key, method);
return method;
Expand All @@ -161,10 +185,6 @@ private static Method findViaSetAccessible(String propertyName, Class<?> aClass,
Class<?> currentClass = aClass;
while (currentClass != null) {
String key = mkKey(currentClass, propertyName);
Method method = METHOD_CACHE.get(key);
if (method != null) {
return method;
}

Predicate<Method> whichMethods = mth -> {
if (dfeInUse) {
Expand All @@ -180,7 +200,7 @@ private static Method findViaSetAccessible(String propertyName, Class<?> aClass,
if (m.isPresent()) {
try {
// few JVMs actually enforce this but it might happen
method = m.get();
Method method = m.get();
method.setAccessible(true);
METHOD_CACHE.putIfAbsent(key, method);
return method;
Expand All @@ -196,11 +216,8 @@ private static Object getPropertyViaFieldAccess(Object object, String propertyNa
Class<?> aClass = object.getClass();
String key = mkKey(aClass, propertyName);
try {
Field field = FIELD_CACHE.get(key);
if (field == null) {
field = aClass.getField(propertyName);
FIELD_CACHE.putIfAbsent(key, field);
}
Field field = aClass.getField(propertyName);
FIELD_CACHE.putIfAbsent(key, field);
return field.get(object);
} catch (NoSuchFieldException e) {
if (!USE_SET_ACCESSIBLE.get()) {
Expand Down