Skip to content

Bugfix for SDL check if an Interface is implemented correctly #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andimarek merged 1 commit into from
Nov 11, 2022
+32 −2
Merged

Bugfix for SDL check if an Interface is implemented correctly #3014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/graphql/schema/idl/ImplementingTypesChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,9 @@ private void checkArgumentConsistency(
if (objectArg == null) {
errors.add(new MissingInterfaceFieldArgumentsError(typeOfType, objectTypeDef, interfaceTypeDef, objectFieldDef));
} else {
String interfaceArgStr = AstPrinter.printAstCompact(interfaceArg);
String objectArgStr = AstPrinter.printAstCompact(objectArg);
// we need to remove the not relevant applied directives on the argument definitions to compare
String interfaceArgStr = AstPrinter.printAstCompact(interfaceArg.transform(builder -> builder.directives(emptyList())));
String objectArgStr = AstPrinter.printAstCompact(objectArg.transform(builder -> builder.directives(emptyList())));
if (!interfaceArgStr.equals(objectArgStr)) {
errors.add(new InterfaceFieldArgumentRedefinitionError(typeOfType, objectTypeDef, interfaceTypeDef, objectFieldDef, objectArgStr, interfaceArgStr));
}
Expand Down
29 changes: 29 additions & 0 deletions src/test/groovy/graphql/schema/idl/SchemaTypeCheckerTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,35 @@ class SchemaTypeCheckerTest extends Specification {

}

def "directives on arguments are not relevant"() {
def spec = """
directive @d on ARGUMENT_DEFINITION
interface InterfaceType {
fieldB(arg1 : String = "defaultVal", arg2 : String @d, arg3 : Int @d) : String
}

type BaseType {
fieldX : Int
}

extend type BaseType implements InterfaceType {
fieldB(arg1 : String = "defaultVal" @d, arg2 : String, arg3 : Int) : String
}

schema {
query : BaseType
}
"""

def result = check(spec)

expect:
result.isEmpty()

}



def "test field arguments on object can contain additional optional arguments"() {
def spec = """
interface InterfaceType {
Expand Down