Skip to content

Use the non deprecated method in InstrumentationExamples.java #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dondonz merged 2 commits into from
Aug 29, 2023
Merged

Use the non deprecated method in InstrumentationExamples.java #3265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e2a771
Update InstrumentationExamples.java
appreciated Jul 7, 2023
8b28f4c
Add import
dzhou-atlassian Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/test/groovy/readme/InstrumentationExamples.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import graphql.execution.instrumentation.fieldvalidation.FieldValidationEnvironment;
import graphql.execution.instrumentation.fieldvalidation.FieldValidationInstrumentation;
import graphql.execution.instrumentation.fieldvalidation.SimpleFieldValidation;
import graphql.execution.instrumentation.parameters.InstrumentationCreateStateParameters;
import graphql.execution.instrumentation.parameters.InstrumentationExecutionParameters;
import graphql.execution.instrumentation.parameters.InstrumentationFieldFetchParameters;
import graphql.execution.instrumentation.tracing.TracingInstrumentation;
Expand Down Expand Up @@ -64,7 +65,7 @@ void recordTiming(String key, long time) {

class CustomInstrumentation extends SimplePerformantInstrumentation {
@Override
public InstrumentationState createState() {
public @Nullable InstrumentationState createState(InstrumentationCreateStateParameters parameters) {
//
// instrumentation state is passed during each invocation of an Instrumentation method
// and allows you to put stateful data away and reference it during the query execution
Expand Down