Skip to content

unwrap ForwardingSubchannel during Picks #12658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivaspeaks merged 7 commits into from
Feb 20, 2026
Merged

unwrap ForwardingSubchannel during Picks #12658

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ac409fb
unwrap Forwarding subchannel
shivaspeaks Feb 12, 2026
7ed0cc9
address comments
shivaspeaks Feb 18, 2026
9941ef5
use 2026 in Copyright
shivaspeaks Feb 18, 2026
bafa9a1
rename APIs
shivaspeaks Feb 19, 2026
600c22b
add TODO
shivaspeaks Feb 19, 2026
b18ca55
update TODO
shivaspeaks Feb 19, 2026
17b3a3e
add VisibleForTestingAnnotation
shivaspeaks Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update TODO
  • Loading branch information
@shivaspeaks
shivaspeaks committed Feb 19, 2026
commit b18ca55cb4900c8d61303b107c3946df2796142e
5 changes: 2 additions & 3 deletions api/src/main/java/io/grpc/LoadBalancer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,9 +632,8 @@ private PickResult(
* stream is created at all in some cases.
* @since 1.3.0
*/
// TODO(shivaspeaks): We need to deprecate old APIs and create new ones.
// Ideally these static methods should start with "of.." instead of "with.."
// to have consistency with other classes.
// TODO(shivaspeaks): Need to deprecate old APIs and create new ones,
// per https://github.com/grpc/grpc-java/issues/12662.
public static PickResult withSubchannel(
Subchannel subchannel, @Nullable ClientStreamTracer.Factory streamTracerFactory) {
return new PickResult(
Expand Down