Fix typos#683
Merged
Merged
Conversation
Lysxia
approved these changes
Dec 29, 2025
Lysxia
left a comment
Lysxia
left a comment
Contributor
There was a problem hiding this comment.
OK. Consider upstreaming this to the simdutf project too.
Bodigrim
reviewed
Dec 29, 2025
| } | ||
| #endif | ||
| #define SIMDUTF_GET_CURRENT_IMPLEMENTION | ||
| #define SIMDUTF_GET_CURRENT_IMPLEMENTATION |
Contributor
There was a problem hiding this comment.
I'm somewhat confused that this #define is changed only in one location. Is it unused anywhere else?
We should probably update simdutf to the latest release anyway, we are quite far behind.
Contributor
There was a problem hiding this comment.
I checked and it's not used anywhere. Maybe it's meant to be an exported macro? I had forgotten that the simdutf source is generated, so @kianmeng if you want your changes to persist you really should upstream them to simdutf.
Contributor
Author
There was a problem hiding this comment.
@Lysxia Noted, PR added to upstream. simdutf/simdutf#888
Contributor
Author
|
🥳 🥳 🥳 🥳 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found via
codespell -L te,vew,out,yot,lamda,ot,tje,seh,otu,cche,ue,bu,yhe,writen,clen,ofo,alo,haskandtypos --hidden --format brief