Skip to content

Feat: Adding Corona Graph Product#2817

Open
gulshan-123 wants to merge 17 commits into
igraph:mainfrom
gulshan-123:feat/corona-prod
Open

Feat: Adding Corona Graph Product#2817
gulshan-123 wants to merge 17 commits into
igraph:mainfrom
gulshan-123:feat/corona-prod

Conversation

@gulshan-123

@gulshan-123 gulshan-123 commented Aug 7, 2025

Copy link
Copy Markdown
Contributor
  • By submitting this pull request, I assign the copyright of my contribution to The igraph development team.

TODO: 1. Update docs, once direction parameter for digraph is confirmed

@codecov

codecov Bot commented Aug 7, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.57%. Comparing base (534af07) to head (afe3af0).
⚠️ Report is 102 commits behind head on main.

Files with missing lines Patch % Lines
src/operators/products.c 97.43% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2817      +/-   ##
==========================================
+ Coverage   75.56%   75.57%   +0.01%     
==========================================
  Files         406      406              
  Lines       75790    75829      +39     
  Branches    15051    15057       +6     
==========================================
+ Hits        57267    57305      +38     
- Misses      18523    18524       +1     
Files with missing lines Coverage Δ
src/operators/products.c 95.96% <97.43%> (+0.27%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534af07...afe3af0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gulshan-123

Copy link
Copy Markdown
Contributor Author

@szhorvat, (taken from previous PR)
For corona products:
image

  1. If the graphs are directed, then the new edges from central graph to the outer graph may have two possible direction. Should we add a direction parameter to decide the directionality? We may use IGRAPH_IN and IGRAPH_OUT (or new constants?).
  2. Total number of vertex is v1.(v2+1), differing from the other products which have v1.v2.

I think a separate new functions for corona product may be added which will have a direction parameter (separate function is also for rooted product). we will write about new vertex number and indices in its docs. I think this will also keep docs of normal graph product clean. ??

@szhorvat

szhorvat commented Aug 7, 2025

Copy link
Copy Markdown
Member

Definitely a separate function. I'll look at the directedness issue when I get the time, but this should be a separate function just because of the different vertex ID mapping.

@gulshan-123 gulshan-123 marked this pull request as ready for review August 8, 2025 13:28
@gulshan-123

gulshan-123 commented Aug 8, 2025

Copy link
Copy Markdown
Contributor Author

@szhorvat, I have added the corona product. Currently, I have added a parameter mode specifying about direction from central to outer graph in digraph product (to be discussed).
I have also added the vertex id mapping in the docs.
(No rush for review, just keeping you informed)

@ntamas ntamas changed the base branch from develop to master September 19, 2025 13:19
@szhorvat

Copy link
Copy Markdown
Member

@ntamas This is not a blocker for 1.0, but let me take a look if I can review it in time ... it'd be nice to include it.

@gulshan-123

Copy link
Copy Markdown
Contributor Author

Hi @szhorvat, any more work to do/suggestions to this PR? As far as I remember, we were discussing about the direction parameter to be included for directed graphs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants