Fix int32_t overflow in intl_charFromString() capacity calculation#113
Open
iliaal wants to merge 1 commit into
Open
Fix int32_t overflow in intl_charFromString() capacity calculation#113iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
intl_charFromString() computed the UTF-8 output capacity as from.length() * 3 in int32_t arithmetic. For a UnicodeString longer than INT32_MAX/3 UTF-16 units the multiply overflows (UB); capacity can go negative, making zend_string_alloc() request a near-SIZE_MAX block, or wrap small, undersizing the buffer that u_strToUTF8WithSub() then writes into. Reject the over-long input with U_BUFFER_OVERFLOW_ERROR up front, mirroring the existing INT32_MAX guard in the sibling intl_stringFromChar().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
intl_charFromString() computed the UTF-8 output capacity as from.length() * 3 in int32_t arithmetic. For a UnicodeString longer than INT32_MAX/3 UTF-16 code units the multiply overflows: capacity can go negative (zend_string_alloc() then requests a near-SIZE_MAX block) or wrap small, undersizing the buffer that u_strToUTF8WithSub() writes into. Reject the over-long input with U_BUFFER_OVERFLOW_ERROR up front, mirroring the INT32_MAX guard already present in the sibling intl_stringFromChar(). The input is always ICU-produced output, so triggering needs a multi-GB UnicodeString; there is no portable red/green test, and the fix matches the project's symmetric-path convention.