[UR][L0v2] Fork-join pattern#22333
Draft
KFilipek wants to merge 3 commits into
Draft
Conversation
kswiecicki
reviewed
Jun 23, 2026
| if (srcQueue->queueIsGraphCapteEnabledExp(&srcCaptureActive) == | ||
| UR_RESULT_SUCCESS && | ||
| srcCaptureActive) { | ||
| return captureCmdListManagerIdx; |
Contributor
There was a problem hiding this comment.
This doesn't update the state of the out-of-order queue. Looking at the Record&Replay docs, I believe the secondary command list should temporarily enter the capturing state until the primary cmd list stopped recording via creating a graph.
Your current implementation ensures that only the operations with an event dependency from the primary queue would end up in the correct cmd list. Subsequent operations to secondary queue might not have the event dependancies, but they should also be recorded. Secondary queue exits temporary recording state when the primary queue finishes the graph.
KFilipek
force-pushed
the
worktree-urt-1059-fork-join
branch
from
be5b21e to
ebf611a
Compare
Route operations waiting on an event from a capturing queue to the capture command list instead of an arbitrary one, so the fork is recorded.
Avoids forking the other command lists, which would never join back.
KFilipek
force-pushed
the
worktree-urt-1059-fork-join
branch
2 times, most recently
from
49d0b8c to
3b32879
Compare
KFilipek
force-pushed
the
worktree-urt-1059-fork-join
branch
from
3b32879 to
581b5f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The L0v2 out-of-order queue uses 4 command list managers but records graph capture only on manager 0. Two paths broke the fork-join pattern:
capture, so queueIsGraphCaptureEnabledExp returned false. Fixed by routing such ops to the capture command list when any wait event comes from a capturing queue.
capture error. Fixed by applying the barrier on the capture list only while capture is active.
Removes the UUR_KNOWN_FAILURE_ON(LevelZeroV2) guard from the ForkJoinPattern conformance test.